Skip to content

Conversation

@seratch
Copy link
Member

@seratch seratch commented Oct 15, 2025

For future releases, we may want to use trusted publishing: https://docs.npmjs.com/trusted-publishers

This pull request adds the required GitHub Actions job for it.

@seratch seratch requested a review from gabor-openai October 15, 2025 05:21
@gabor-openai gabor-openai requested a review from Copilot October 16, 2025 17:42
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds GitHub Actions support for trusted publishing to npm, enabling secure package publishing without storing secrets. The workflow is configured to trigger on version tags and uses OpenID Connect (OIDC) for authentication.

Key changes:

  • Added a new GitHub Actions workflow for automated package publishing
  • Configured OIDC permissions for trusted publishing authentication
  • Set up build, test, and publish pipeline triggered by version tags

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

run: npm install -g npm@latest
- run: npm ci
- run: npm run build --if-present
- run: npm run test -- --run
Copy link

Copilot AI Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The --run flag appears to be specific to Vitest, but this assumes a particular test framework. Consider using npm test without additional flags for better compatibility, or add a condition to check if the test script exists before running it.

Suggested change
- run: npm run test -- --run
- run: npm test

Copilot uses AI. Check for mistakes.
Copy link
Collaborator

@gabor-openai gabor-openai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TY

@gabor-openai gabor-openai merged commit f671d97 into main Oct 21, 2025
1 check passed
@gabor-openai gabor-openai deleted the public-job branch November 18, 2025 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants