Enable running tests in CI #8
Merged
+51
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seratch
commented
Oct 3, 2025
|
|
||
| def __post_init__(self) -> None: | ||
| """Validate required fields and consistency.""" | ||
| if "checked_text" not in self.info: |
There was a problem hiding this comment.
The only main code change is this. This validation is not compatible with the current tests. If we think tests should be changed, I am happy to work on it later.
There was a problem hiding this comment.
Removing this line is fine
|
|
||
| model = _resolve_ctx_requirements(check) | ||
| fields = getattr(model, "model_fields", getattr(model, "__fields__", {})) | ||
| # Prefer Pydantic v2 API without eagerly touching deprecated v1 attributes |
There was a problem hiding this comment.
this is to resolve warning:
tests/unit/test_registry.py::test_resolve_ctx_protocol_creates_model
/Users/seratch/code/openai-guardrails-python/tests/unit/test_registry.py:40: PydanticDeprecatedSince20: The `__fields__` attribute is deprecated, use `model_fields` instead. Deprecated in Pydantic V2.0 to be removed in V3.0. See Pydantic V2 Migration Guide at https://errors.pydantic.dev/2.11/migration/
fields = getattr(model, "model_fields", getattr(model, "__fields__", {}))
-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
|
Ah, some tests expect OPENAI_API_KEY env variable; I didn't detect it locally. Will fix them too. |
steven10a
approved these changes
Oct 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request enables running all the tests in CI.