Skip to content

fix(audio): add fallback overload types #1109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 30, 2024
Merged

fix(audio): add fallback overload types #1109

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1a44af9
fix(audio): use export type
RobertCraigie Sep 30, 2024
56fc7ab
fix(audio): add fallback overload types
RobertCraigie Sep 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions src/resources/audio/audio.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,12 +29,20 @@ export namespace Audio {
export import TranscriptionVerbose = TranscriptionsAPI.TranscriptionVerbose;
export import TranscriptionWord = TranscriptionsAPI.TranscriptionWord;
export import TranscriptionCreateResponse = TranscriptionsAPI.TranscriptionCreateResponse;
export import TranscriptionCreateParams = TranscriptionsAPI.TranscriptionCreateParams;
export type TranscriptionCreateParams<
ResponseFormat extends AudioAPI.AudioResponseFormat | undefined =
| AudioAPI.AudioResponseFormat
| undefined,
> = TranscriptionsAPI.TranscriptionCreateParams<ResponseFormat>;
export import Translations = TranslationsAPI.Translations;
export import Translation = TranslationsAPI.Translation;
export import TranslationVerbose = TranslationsAPI.TranslationVerbose;
export import TranslationCreateResponse = TranslationsAPI.TranslationCreateResponse;
export import TranslationCreateParams = TranslationsAPI.TranslationCreateParams;
export type TranslationCreateParams<
ResponseFormat extends AudioAPI.AudioResponseFormat | undefined =
| AudioAPI.AudioResponseFormat
| undefined,
> = TranslationsAPI.TranslationCreateParams<ResponseFormat>;
export import Speech = SpeechAPI.Speech;
export import SpeechModel = SpeechAPI.SpeechModel;
export import SpeechCreateParams = SpeechAPI.SpeechCreateParams;
Expand Down
7 changes: 6 additions & 1 deletion src/resources/audio/transcriptions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ export class Transcriptions extends APIResource {
body: TranscriptionCreateParams<'srt' | 'vtt' | 'text'>,
options?: Core.RequestOptions,
): Core.APIPromise<string>;
create(body: TranscriptionCreateParams, options?: Core.RequestOptions): Core.APIPromise<Transcription>;
create(
body: TranscriptionCreateParams,
options?: Core.RequestOptions,
Expand Down Expand Up @@ -210,5 +211,9 @@ export namespace Transcriptions {
export import TranscriptionVerbose = TranscriptionsAPI.TranscriptionVerbose;
export import TranscriptionWord = TranscriptionsAPI.TranscriptionWord;
export import TranscriptionCreateResponse = TranscriptionsAPI.TranscriptionCreateResponse;
export import TranscriptionCreateParams = TranscriptionsAPI.TranscriptionCreateParams;
export type TranscriptionCreateParams<
ResponseFormat extends AudioAPI.AudioResponseFormat | undefined =
| AudioAPI.AudioResponseFormat
| undefined,
> = TranscriptionsAPI.TranscriptionCreateParams<ResponseFormat>;
}
7 changes: 6 additions & 1 deletion src/resources/audio/translations.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ export class Translations extends APIResource {
body: TranslationCreateParams<'text' | 'srt' | 'vtt'>,
options?: Core.RequestOptions,
): Core.APIPromise<string>;
create(body: TranslationCreateParams, options?: Core.RequestOptions): Core.APIPromise<Translation>;
create(
body: TranslationCreateParams,
options?: Core.RequestOptions,
Expand Down Expand Up @@ -101,5 +102,9 @@ export namespace Translations {
export import Translation = TranslationsAPI.Translation;
export import TranslationVerbose = TranslationsAPI.TranslationVerbose;
export import TranslationCreateResponse = TranslationsAPI.TranslationCreateResponse;
export import TranslationCreateParams = TranslationsAPI.TranslationCreateParams;
export type TranslationCreateParams<
ResponseFormat extends AudioAPI.AudioResponseFormat | undefined =
| AudioAPI.AudioResponseFormat
| undefined,
> = TranslationsAPI.TranslationCreateParams<ResponseFormat>;
}