feat(azure): Realtime API support #1287
Conversation
deyaaeldeen
force-pushed
the
feat/azure-rt-factory
branch
from
a28dbcc to
e90657b
Compare
stainless-app
bot
force-pushed
the
next
branch
from
d1d50c8 to
fb61fc2
Compare
deyaaeldeen
force-pushed
the
feat/azure-rt-factory
branch
from
e90657b to
f2e649f
Compare
| type: 'session.update', | ||
| session: { | ||
| modalities: ['foo'] as any, | ||
| modalities: ['text'], |
There was a problem hiding this comment.
oops thanks for fixing!
src/beta/realtime/websocket.ts
Outdated
| if (azureCheck) { | ||
| if (this.url.searchParams.get('Authorization') !== null) { | ||
| this.url.searchParams.set('Authorization', '<REDACTED>'); | ||
| } else { | ||
| this.url.searchParams.set('api-key', '<REDACTED>'); | ||
| } | ||
| } |
There was a problem hiding this comment.
question: why do we need to do this?
There was a problem hiding this comment.
We try not to expose secrets and this.url is exposed on the client. Follows the same spirit of #1218
src/beta/realtime/websocket.ts
Outdated
| props: { | ||
| model: string; | ||
| dangerouslyAllowBrowser?: boolean; | ||
| onUrl?: (url: URL) => void; |
There was a problem hiding this comment.
nit
| onUrl?: (url: URL) => void; | |
| onURL?: (url: URL) => void; |
also would be nice to mention / mark this as internal-only
| onUrl?: (url: URL) => void; | |
| /** | |
| * Callback to mutate the URL, needed for Azure. | |
| * @internal | |
| */ | |
| onURL?: (url: URL) => void; |
There was a problem hiding this comment.
Addressed in 9a73f6f
src/beta/realtime/websocket.ts
Outdated
| this.url = buildRealtimeURL(client, props.model); | ||
| props.onUrl?.(this.url); | ||
|
|
||
| const azureCheck = isAzure(client); |
There was a problem hiding this comment.
optional suggestion: I would personally find this easier to read if isAzure(client) was just inlined instead of extracted to a variable like this
There was a problem hiding this comment.
Addressed in 9a73f6f
src/beta/realtime/internal-base.ts
Outdated
| import { RealtimeClientEvent, RealtimeServerEvent, ErrorEvent } from '../../resources/beta/realtime/realtime'; | ||
| import { EventEmitter } from '../../lib/EventEmitter'; | ||
| import { OpenAIError } from '../../error'; | ||
| import OpenAI, { AzureOpenAI } from 'openai'; |
There was a problem hiding this comment.
nit
| import OpenAI, { AzureOpenAI } from 'openai'; | |
| import OpenAI, { AzureOpenAI } from '../../index'; |
There was a problem hiding this comment.
Addressed in 9a73f6f
| console.log(result.choices[0]!.message?.content); | ||
| ``` | ||
|
|
||
| ### Realtime API |
There was a problem hiding this comment.
cc @kwhinnery-openai I suspect you'll want to do some wordsmithing here
RobertCraigie
changed the title
3 participants
Support Azure Realtime API
In order to do so, this PR adds an azure factory method to
OpenAIRealtimeWebSocketandOpenAIRealtimeWSclasses that can handle asynchronous operations required during WebSocket connection setup.Key Changes
1. New
azureMethodazuremethod enables asynchronous fetching of the Azure AD token and then pass it to the class constructor.2. New
_getAzureADTokenMethod inAzureOpenAI_getAzureADTokenmethod in theAzureOpenAIclass to provide refreshed Azure AD tokens.