fix(zod): warn on optional field usage #1469
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobertCraigie
force-pushed
the
robert/warn-structured-outputs
branch
from
270adfa to
da548f6
Compare
kwhinnery-openai
approved these changes
Apr 18, 2025
Merged
Merged
SkinnnyJay
pushed a commit
to SkinnnyJay/openai-node
that referenced
this pull request
Sep 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The API doesn't support optional fields and the SDK is accidentally marking all fields as
required, even when they've been marked with.optional().Fixing this would be a breaking change, so we're adding a warning and fixing this properly in v5.