fix(zod): avoid adding redundant not to optional schemas
#1593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobertCraigie
changed the title
not to optional schemas
Merged
SkinnnyJay
pushed a commit
to SkinnnyJay/openai-node
that referenced
this pull request
Sep 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes being requested
Adjusted optional field handling so that JSON Schema generation no longer emits redundant “not” constraints when an optional property is nested inside an object. The parser now checks that the current path begins with the property path before omitting the “not” clause
Updated the test snapshot to match the corrected schema output, where optional nullable enums only include the union of the enum type and null without the extra “not” block
Additional context & links
Fixes #1365