Skip to content

chore(pydantic v1): exclude specific properties when rich printing #1751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 26, 2024
Merged

chore(pydantic v1): exclude specific properties when rich printing #1751

merged 2 commits into from
Sep 26, 2024

Conversation

RobertCraigie
Copy link
Collaborator

@RobertCraigie RobertCraigie commented Sep 26, 2024 •
edited
Loading

Previously we'd print things like this

ParsedChatCompletion[MathResponse](
    id='chatcmpl-ABqjDEHcQeJS1zQKQsjk7pryPMOPl',
    # ...
    _request_id='req_8b371ab5485eea304486a17d9e210bcc',
    __exclude_fields__={'__exclude_fields__', '_request_id'}
)

but we didn't intend for _request_id and __exclude_fields__ to be printed, this PR fixes that

@RobertCraigie RobertCraigie changed the base branch from main to next September 26, 2024 22:12
@RobertCraigie RobertCraigie marked this pull request as ready for review September 26, 2024 22:12
@RobertCraigie RobertCraigie requested a review from a team as a code owner September 26, 2024 22:12
@RobertCraigie RobertCraigie merged commit af535ce into next Sep 26, 2024
2 checks passed
@RobertCraigie RobertCraigie deleted the robert/fix-pydantic-v1-request-id-print branch September 26, 2024 22:12
@stainless-app stainless-app bot mentioned this pull request Sep 26, 2024
Merged
stainless-app bot pushed a commit that referenced this pull request Sep 26, 2024
@RobertCraigie @stainless-app
chore(pydantic v1): exclude specific properties when rich printing (#…
e1aeeb0 
…1751)
cgayapr pushed a commit to cgayapr/openai-python that referenced this pull request Dec 14, 2024
@RobertCraigie @stainless-app
chore(pydantic v1): exclude specific properties when rich printing (o…
d8334fd 
…penai#1751)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@RobertCraigie