Update azure.py #1893
Closed
Update azure.py #1893
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Examples of values for azure_endpoint include the trailing forward slash, but 4 string concatenations in this file are not compatible with the inclusion of the trailing character. This commit makes them agnostic to the trailing character.
1 task
|
Thanks for the PR! It looks like the f-string syntax you're using only works on Python >= 3.12, can you update it to work on older versions? |
|
Fixed in #1935 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes being requested
Examples of values for azure_endpoint include the trailing forward slash, but 4 string concatenations in src/openai/lib/azure.py are not compatible with the inclusion of the trailing character. This commit makes them agnostic to the trailing character.
Additional context & links
Here's an example where an example endpoint includes the trailing forward slash:
openai-python/examples/azure.py
Line 29 in 83f4774