remove hardcoded model parameter and make it configurable#108
Open
ValorLin wants to merge 1 commit intoopenai:mainfrom
Open
remove hardcoded model parameter and make it configurable#108ValorLin wants to merge 1 commit intoopenai:mainfrom
ValorLin wants to merge 1 commit intoopenai:mainfrom
Conversation
|
Thanks for the patch! It fixed the bug for me, and I recommend they take it. |
|
Lol I had not seen this PR, I've opened my own to solve the same issue. We have slightly different approaches, I've opted to make the choice of the model a required parameter of the client's So my thinking was that the model arg needs to either be explicit or the default should be the cheapest one (blah-blah-mini). I realize I should probably make it mandatory in the API's OpenAI doesn't care about PRs I assume, seeing the date of yours? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: remove hardcoded model parameter and make it configurable
Fix #89