Skip to content

docs(openapi-fetch): remove line about new examples #2339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 11, 2025

Conversation

gzm0
Copy link
Contributor

@gzm0 gzm0 commented May 27, 2025

As discussed in the maintainer's chat: It seems that examples mostly showcase how to integrate an (arbitrary) function/client into a specific framework.

As a result, the examples have very little openapi-fetch specific content, but a lot of framework specific content. This, in our opinion, tips the balance of whether the maintenance burden is worth the ease of use.

As discussed in the maintainer's chat: It seems that examples mostly
showcase how to integrate an (arbitrary) function/client into a
specific framework.

As a result, the examples have very little openapi-fetch specific
content, but a lot of framework specific content. This, in our
opinion, tips the balance of whether the maintenance burden is worth
the ease of use.
@gzm0 gzm0 requested a review from a team as a code owner May 27, 2025 11:14
@gzm0 gzm0 requested a review from drwpow May 27, 2025 11:14
Copy link

netlify bot commented May 27, 2025

Deploy Preview for openapi-ts ready!

Name Link
🔨 Latest commit f93f49b
🔍 Latest deploy log https://app.netlify.com/projects/openapi-ts/deploys/689a05c187e26b00085d62ab
😎 Deploy Preview https://deploy-preview-2339--openapi-ts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

changeset-bot bot commented May 27, 2025

⚠️ No Changeset found

Latest commit: f93f49b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@gzm0
Copy link
Contributor Author

gzm0 commented May 28, 2025

@HasutoSasaki just to kick off the discussion, we (some of the maintainers, @drwpow and I) feel that adding new examples is not worth the maintenance overhead (reviews, keeping it up to date).

One big reason behind this is that most examples seem to primarily showcase how to call use an arbitrary async in a specific framework. As such, it is mostly framework documentation and not openapi-fetch documentation.

As I'm writing this, I wonder if a middle ground could be to have links to relevant documentation on the framework side.

@HasutoSasaki
Copy link
Contributor

@gzm0
I’m very sorry for the delay in replying.

First of all, thank you for your thoughtful feedback!

You’re absolutely right — the example I provided was more about demonstrating how to use openapi-typescript with Nuxt 3, rather than showcasing the library itself. I now understand that including it directly in the project may not be ideal, as it would create ongoing maintenance overhead.

That said, I’d like to suggest a possible alternative: what if I host the Nuxt 3 + openapi-typescript example in my own repository, and you link to it from this project? This way, it could still help users without adding any maintenance burden to this repository.

@gzm0
Copy link
Contributor Author

gzm0 commented Jun 2, 2025

@HasutoSasaki I think that is an excellent idea! I think managing the links to such examples is absolutely within reason for the core maintainers to do.

@HasutoSasaki
Copy link
Contributor

@gzm0
Thank you!
I’ll prepare the example in my own repository, so please give me a little more time.

@HasutoSasaki
Copy link
Contributor

@gzm0
Sorry for the delay
I have a sample in my repository
Would you like to set up a new PR to add the link?

nuxt3 example repository

@gzm0
Copy link
Contributor Author

gzm0 commented Jun 24, 2025

I have a sample in my repository

Fantastic!

Would you like to set up a new PR to add the link?

I would suggest you just amend your existing PR (#2331) and the I'll close this one (or amend it to clarify examples should be externally hosted).

@drwpow drwpow merged commit 3da2ca4 into openapi-ts:main Aug 11, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants