Skip to content

Conversation

@kkrawczyk123
Copy link
Collaborator

Add deactivation of receiving bin to receiving tests to limit the number of created bin locations

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds cleanup logic to deactivate receiving bin locations created during test execution across multiple receiving test files. The change aims to prevent accumulation of bin locations in the test environment.

  • Adds AppConfig import to access receiving bin prefix configuration
  • Adds "Deactivate receiving bin" cleanup step to afterEach hooks in test files
  • Fixes minor formatting and spelling issues in existing code

Reviewed Changes

Copilot reviewed 20 out of 20 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
validationsOnEditAndReceive.test.ts Splits test suite, adds bin deactivation to second suite, restructures test for "Receive from different locations"
validationsOnDeliverOnDate.test.ts Adds bin deactivation step to afterEach hook
tableShortcutsInReceiving.test.ts Adds bin deactivation step, fixes trailing whitespace formatting issues
sortByAlphabeticalOrderAndRemainInputs.test.ts Adds bin deactivation step to afterEach hook
rollbackStatusChanges.test.ts Adds bin deactivation step to afterEach hook
receivingStatusChanges.test.ts Adds bin deactivation step to afterEach hook
receiveToHoldBin.test.ts Moves variable declarations, adds bin deactivation step, fixes "Deatitave" typo
receiveInbound.test.ts Adds bin deactivation step, restructures nested test suite
lotExpirySystemUpdateOnReceiving.test.ts Adds bin deactivation step within while loop in afterEach
importReceivingTemplate.test.ts Adds bin deactivation step, fixes formatting in template population
exportReceivingTemplate.test.ts Adds bin deactivation step, fixes trailing comma
editsInReceiving.test.ts Adds bin deactivation step to afterEach hook
editOriginalLineQtyTo0.test.ts Adds bin deactivation step to both test suites
editBinLocationWhenReceive.test.ts Moves variable declarations, adds bin deactivation to three test suites
cancelRemainingQty.test.ts Adds bin deactivation step with trailing whitespace
assertRecipientField.test.ts Adds bin deactivation step to afterEach hook
assertQtyInputs.test.ts Adds bin deactivation step to afterEach hook
assertCreationOfReceivingBin.test.ts Adds bin deactivation step to afterEach hook
assertCreationOfGoodsReceiptNote.test.ts Adds bin deactivation step with trailing whitespace
assertBinLocationField.test.ts Adds bin deactivation step, fixes indentation and typo in step description

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 24 out of 24 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@alannadolny alannadolny merged commit 13b2503 into main Nov 26, 2025
1 check passed
@alannadolny alannadolny deleted the OBPIH-7029 branch November 26, 2025 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants