Fix multi-select values in metadata not removable (Safari) #1496
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a bug where values could not be removed from multi-select fields, like presenters or contributors in the event metadata. When clicking on the "X" of the blue box with the value, the field would leave edit mode but the value was not removed. This fix has an unpleasant side effect, where multi-select fields will not properly blur anymore when left via tab navigation. I am not sure how to properly fix this with the current code.
Contributor
|
Use Run test server using develop.opencast.org as backend: Specify a different backend like stable.opencast.org: It may take a few seconds for the interface to spin up. |
Contributor
|
This pull request is deployed at test.admin-interface.opencast.org/1496/2026-01-05_11-52-27/ . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where values could not be removed from multi-select fields, like presenters or contributors in the event metadata. When clicking on the "X" of the blue box with the value, the field would leave edit mode but the value was not removed. This is due to a timing issue most notable in Safari. This patch fixes the issue by making the field not leave edit mode when clicking on "X", which is how multi-select fields behaved in 18.x as well.
This fix has an unpleasant side effect, where multi-select fields will not properly blur anymore when left via tab navigation. I am not sure how to properly fix this with the current code.