Skip to content

Allow translating preview mode status in tooltip #1667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Arnei wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Allow translating preview mode status in tooltip #1667

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/i18n/locales/en-US.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,8 @@

"video": {
"previewButton": "Preview Mode",
"previewButton-tooltip": "Skips deleted segments when playing the video. Currently {{status}}. Hotkey: {{hotkeyName}}",
"previewButton-tooltip-on": "Skips deleted segments when playing the video. Currently on. Hotkey: {{hotkeyName}}",
"previewButton-tooltip-off": "Skips deleted segments when playing the video. Currently off. Hotkey: {{hotkeyName}}",
"previewButton-aria": "Enable or disable preview mode. Hotkey: {{hotkeyName}}.",
"playButton-tooltip": "Play video",
"pauseButton-tooltip": "Pause video",
Expand Down
3 changes: 1 addition & 2 deletions src/main/VideoControls.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,8 +162,7 @@ const PreviewMode: React.FC<{

return (
<ThemedTooltip
title={t("video.previewButton-tooltip", {
status: (isPlayPreview ? "on" : "off"),
title={t(isPlayPreview ? "video.previewButton-tooltip-on" : "video.previewButton-tooltip-off", {
hotkeyName: rewriteKeys(KEYMAP.videoPlayer.preview.key),
})}
>
Expand Down
Loading