Reindex more things

[gregorydlogan]

This PR prompts users reindexing for allow-by-episode-role-id to reindex more things. As reported in Matrix, only reindexing the ACL gets you events without any metadata.

This targets 18.x since that's where the index migration happens.

Your pull request should…

• have a concise title
• close an accompanying issue if one exists
• be against the correct branch
• include migration scripts and documentation, if appropriate
• pass automated tests
• have a clean commit history
• have proper commit messages (title and body) for all commits
• explain why it needs to be merged into the legacy branch, if it is targeting the legacy branch
• include a release note if a feature, or supports a feature (ie, backend part of a frontend feature)

[lkiesow]

What you are reporting here essentially means that calling the .../ACL endpoint effectively destroys your index? It feels like just changing the documentation for the upgrade isn't sufficient.

Do we know why this is happening? Can we easily fix this? We probably should if we can?

If this is hard to fix, we might as well remove the ACL endpoint? That's still preferable to having something that corrupts your data if used.

[gregorydlogan]

The time I saw it causing corruption is if you drop the index completely, then only call to reindex the ACL sub-index. This is, honestly, expected behaviour in that you're telling the system to reindex the ACLs and only the ACLs.

An argument could be made to better protect the user from doing something dumb, but if you have permissions to drop the index completely then there's really only so much we can do.

I'm fine removing the subindex options and just requiring a full AM reindex, but I haven't really thought through the implications of that for real adopters. There's probably a usecase for only doing sub-sections, which would be why that endpoint was added in the first place.