Change subject type from text to mixed_text#7462
Open
geichelberger wants to merge 4 commits intoopencast:developfrom
Open
Change subject type from text to mixed_text#7462geichelberger wants to merge 4 commits intoopencast:developfrom
geichelberger wants to merge 4 commits intoopencast:developfrom
Conversation
| @@ -0,0 +1 @@ | |||
| - Changed type of event and series `subject` field from `text` to `mixed_text`. Which allows better handling of keywords and a consistent handling between UI and external API. No newline at end of file | |||
Member
There was a problem hiding this comment.
This makes an RM's life so much easier.
Suggested change
| - Changed type of event and series `subject` field from `text` to `mixed_text`. Which allows better handling of keywords and a consistent handling between UI and external API. | |
| - [#7462](https://github.com/opencast/opencast/pull/7462/): Changed type of event and series `subject` field from `text` to `mixed_text`. Which allows better handling of keywords and a consistent handling between UI and external API. |
geichelberger
force-pushed
the
mixed_text
branch
from
2e5904c to
377022b
Compare
The subject field of the external api had a custom type iterable_text, this is now replaced with mixed_text.
geichelberger
force-pushed
the
mixed_text
branch
from
ce64be3 to
a716e8a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes the subject type from
texttomixed_text. This allows consistent behaviour between the UI and the External API, as the External API already handles it as a list by splitting the subject field on a comma.The PR does not implement a migration; the code is somewhat backward-compatible.
Your pull request should…