Fix broken step navigation buttons - #1360
Open
lkiesow wants to merge 1 commit into
Open
Conversation
Spreading the result of `css(…)` into the surrounding style object adds a `styles` key, which makes emotion treat the whole object as already serialized and drop every other property. So the buttons only kept their `padding-right`. Use a plain style object again. Fixes opencast#1358 Regression introduced by 1f99aaa
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spreading the result of
css(…)into the surrounding style object adds astyleskey, which makes emotion treat the whole object as already serialized and drop every other property. So the buttons only kept theirpadding-right. Use a plain style object again.Fixes #1358
Regression introduced by 1f99aaa