feat: add required field validation to EnvVarEditor and FileVarEditor#477
Conversation
Disable the Apply button until all required fields are filled, preventing invalid entries with empty values from being saved. Follows the existing isBufferValid pattern from useEndpointEditBuffer. EnvVar: key and value required (plain), key + secret name/key (secret) FileVar: key + mountPath + content required (plain), key + mountPath + secret name/key (secret) Signed-off-by: Kavith Lokuhewage <kaviththiranga@gmail.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (8)
📝 WalkthroughWalkthroughThis PR introduces buffer validation to environment and file variable editor components. New Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Disable the Apply button until all required fields are filled,
preventing invalid entries with empty values from being saved.
Follows the existing isBufferValid pattern from useEndpointEditBuffer.
EnvVar: key and value required (plain), key + secret name/key (secret)
FileVar: key + mountPath + content required (plain), key + mountPath +
secret name/key (secret)
Summary by CodeRabbit