Incorporating suggestions from @gordonje#104
Open
aepton wants to merge 2 commits intoopencivicdata:masterfrom
Open
Incorporating suggestions from @gordonje#104aepton wants to merge 2 commits intoopencivicdata:masterfrom
aepton wants to merge 2 commits intoopencivicdata:masterfrom
Conversation
Contributor
aepton
commented
Dec 16, 2017
aepton
commented
- Adds filing_action to CommitteeAttributeUpdate, same as with Transaction
- Gives Transaction a repeated notes field instead of discrete "description" and "notes" fields
- Adds free-text field for "type" to Committee and gets rid of CommitteeType
- Removes time field from coverage_start_date and coverage_end_date
- Adds repeated "totals" field on Filing
- Makes Filing.election field optional, renames it to "designation"
- Adds is_rejected field to Transaction.amount
- Makes Transaction.date optional
This was referenced Dec 16, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.