add exception for handling vacant committee members#399
Merged
Conversation
hancush
reviewed
Nov 21, 2025
Collaborator
hancush
left a comment
hancush
left a comment
There was a problem hiding this comment.
Two little things, then this is good to go.
Comment on lines
+142
to
+149
| person.add_membership( | ||
| org, | ||
| role=term["memberType"], | ||
| start_date=datetime.datetime.fromisoformat( | ||
| term["startDate"] | ||
| ).date(), | ||
| end_date=datetime.datetime.fromisoformat(term["endDate"]).date(), | ||
| ) |
Collaborator
There was a problem hiding this comment.
Want to add this to an else block? I like to limit the code in the try block to what could potentially fail, for the sake of being explicit.
chicago/people.py
Outdated
Comment on lines
+154
to
+155
| print("Problem adding to Committee:") | ||
| print(error) |
Collaborator
There was a problem hiding this comment.
Should probably use logging.warning – has the benefit of slotting into existing logging seamlessly and if we want to wire up Sentry in the future, we can use the logging integration without having to change these print statements.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chicago: handling case where committee member is vacant, logging if there is a
KeyErrorotherwise