Skip to content

Drop down menus#318

Draft
peterdudfield wants to merge 3 commits intomainfrom
drop-down-menus
Draft

Drop down menus#318
peterdudfield wants to merge 3 commits intomainfrom
drop-down-menus

Conversation

@peterdudfield
Copy link
Contributor

@peterdudfield peterdudfield commented Jul 18, 2025

Pull Request

Description

Upgrade top from

Screenshot 2025-07-18 at 10 48 14

to

Screen.Recording.2025-07-18.at.10.47.31.mov

Similar changes in India

How Has This Been Tested?

Tried it locally

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@peterdudfield peterdudfield requested a review from zakwatts July 18, 2025 09:49
@zakwatts
Copy link
Contributor

I really like this. It feels a lot cleaner!

def main_page():
st.text('This is the Analysis Dashboard India. Please select the page you want on the left hand side')
st.text(
"This is the Analysis Dashboard India. Please select the page you want on the left hand side"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be updated to "Please select the page you want from the menu at the top of this page"

st.Page(adjuster_page, title="🔧 Adjuster")], position="top")
pg = st.navigation(
{
"🏠 Home": [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe "Users" would be better for the title here?

Copy link
Contributor

@zakwatts zakwatts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few small tweaks. Looks good though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants