fix-conflicting versions#198
Conversation
|
@jacobbieker please review |
jacobbieker
left a comment
There was a problem hiding this comment.
Looks good, thanks for this. Just remove the change to the ignored rules, and we can merge this. I do like having everything in the pyproject
pyproject.toml
Outdated
| # Enable pycodestyle (`E`) and Pyflakes (`F`) codes by default. | ||
| select = ["E", "F", "D", "I"] | ||
| ignore = ["D200","D202","D210","D212","D415","D105"] | ||
| ignore = ["D200","D202","D210","D212","D415","D105","D100","D101","D102","D103","D104","D107","D205","D417","E501"] |
There was a problem hiding this comment.
We'd like to keep these rules. I know its failing the checks because of these for now, but I don't want to get rid of them.
There was a problem hiding this comment.
yeah reverted it please take a look .... thanku for your feedback
|
@jacobbieker please review |
|
Conflict resolved please take a look |
jacobbieker
left a comment
There was a problem hiding this comment.
Looks nice, little more change, and then we can merge it.
README.md
Outdated
| pip install graph-weather | ||
| ``` | ||
|
|
||
| ### Versioning |
There was a problem hiding this comment.
This doesn't need to be in the docs. The bump should happen with the CI automatically, so we can leave this out.
pyproject.toml
Outdated
| name = "graph_weather" | ||
| requires-python = ">=3.11" | ||
| version = "1.0.89" | ||
| version = "1.0.128" |
There was a problem hiding this comment.
This needs updating to match the current version, which is one higher, see the bumpversion.cfg file
03e7942 to
b2448fe
Compare
|
Hi @jacobbieker thank you for your patience. I have pushed the latest changes addressing your suggestion. Please take a look |
|
@jacobbieker Is there any high-impact area where I could contribute meaningfully right now? I’m particularly interested in working with this organization long-term and aiming for GSoC 2026, and I want to focus my efforts where they create the most value and learning. I’d really grateful for your guidance on areas that would benefit most from contributions. |
Hi, I don't work for OCF anymore, I just continue to maintain a few of the repos I built, but do still talk and interact with the team quite a bit. I would say look at the good first issues on other repos, those might be good starting points? |
|
Thanks for clarifying. is there any POC so that i can connect to him so that i can talk to him about this ?? |
Pull Request
Description
This pull request updates the project's versioning approach to use
pyproject.tomlas the single source of truth for version information, streamlining the build and release process. The changes ensure that version numbers are consistently managed and automatically synced across the project, and the documentation has been updated to reflect this workflow.Versioning improvements:
.bumpversion.cfgfromsetup.pytopyproject.tomlto makepyproject.tomlthe authoritative version file.pyproject.tomlto1.0.128.setup.pyto dynamically read the version frompyproject.tomlusing a helper function, removing hardcoded version numbers.Documentation updates:
README.mdexplaining the new versioning workflow and instructions for usingbump2versionwithpyproject.toml.Fixes #197