Skip to content

fix-conflicting versions#198

Merged
jacobbieker merged 1 commit intoopenclimatefix:mainfrom
naman9271:fix-version
Jan 12, 2026
Merged

fix-conflicting versions#198
jacobbieker merged 1 commit intoopenclimatefix:mainfrom
naman9271:fix-version

Conversation

@naman9271
Copy link
Contributor

Pull Request

Description

This pull request updates the project's versioning approach to use pyproject.toml as the single source of truth for version information, streamlining the build and release process. The changes ensure that version numbers are consistently managed and automatically synced across the project, and the documentation has been updated to reflect this workflow.

Versioning improvements:

  • Changed the version source in .bumpversion.cfg from setup.py to pyproject.toml to make pyproject.toml the authoritative version file.
  • Updated the version in pyproject.toml to 1.0.128.
  • Refactored setup.py to dynamically read the version from pyproject.toml using a helper function, removing hardcoded version numbers.

Documentation updates:

  • Added a section to README.md explaining the new versioning workflow and instructions for using bump2version with pyproject.toml.

Fixes #197

@naman9271
Copy link
Contributor Author

@jacobbieker please review

Copy link
Member

@jacobbieker jacobbieker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for this. Just remove the change to the ignored rules, and we can merge this. I do like having everything in the pyproject

pyproject.toml Outdated
# Enable pycodestyle (`E`) and Pyflakes (`F`) codes by default.
select = ["E", "F", "D", "I"]
ignore = ["D200","D202","D210","D212","D415","D105"]
ignore = ["D200","D202","D210","D212","D415","D105","D100","D101","D102","D103","D104","D107","D205","D417","E501"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'd like to keep these rules. I know its failing the checks because of these for now, but I don't want to get rid of them.

Copy link
Contributor Author

@naman9271 naman9271 Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah reverted it please take a look .... thanku for your feedback

@naman9271
Copy link
Contributor Author

@jacobbieker please review

@naman9271
Copy link
Contributor Author

Conflict resolved please take a look

Copy link
Member

@jacobbieker jacobbieker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice, little more change, and then we can merge it.

README.md Outdated
pip install graph-weather
```

### Versioning
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't need to be in the docs. The bump should happen with the CI automatically, so we can leave this out.

pyproject.toml Outdated
name = "graph_weather"
requires-python = ">=3.11"
version = "1.0.89"
version = "1.0.128"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs updating to match the current version, which is one higher, see the bumpversion.cfg file

@naman9271
Copy link
Contributor Author

naman9271 commented Jan 12, 2026

Hi @jacobbieker thank you for your patience. I have pushed the latest changes addressing your suggestion. Please take a look

@naman9271
Copy link
Contributor Author

naman9271 commented Jan 12, 2026

@jacobbieker Is there any high-impact area where I could contribute meaningfully right now?

I’m particularly interested in working with this organization long-term and aiming for GSoC 2026, and I want to focus my efforts where they create the most value and learning.

I’d really grateful for your guidance on areas that would benefit most from contributions.

@jacobbieker jacobbieker merged commit 85a5a4d into openclimatefix:main Jan 12, 2026
1 check failed
@jacobbieker
Copy link
Member

@jacobbieker Is there any high-impact area where I could contribute meaningfully right now?

I’m particularly interested in working with this organization long-term and aiming for GSoC 2026, and I want to focus my efforts where they create the most value and learning.

I’d really grateful for your guidance on areas that would benefit most from contributions.

Hi,

I don't work for OCF anymore, I just continue to maintain a few of the repos I built, but do still talk and interact with the team quite a bit. I would say look at the good first issues on other repos, those might be good starting points?

@naman9271
Copy link
Contributor Author

naman9271 commented Jan 12, 2026

Thanks for clarifying.
I’ll start with a few “good first issues” across the other repos and follow up if I find an opportunity to add more impact.

is there any POC so that i can connect to him so that i can talk to him about this ??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Packaging & versioning is broken

2 participants