Transformer UNet for data assimilation and forecasting #203
Closed
SOHAMPAL23 wants to merge 6 commits intoopenclimatefix:mainfrom
Closed
Transformer UNet for data assimilation and forecasting #203SOHAMPAL23 wants to merge 6 commits intoopenclimatefix:mainfrom
SOHAMPAL23 wants to merge 6 commits intoopenclimatefix:mainfrom
Conversation
…rototype" This reverts commit 15abece.
for more information, see https://pre-commit.ci
jacobbieker
requested changes
Jan 16, 2026
Member
jacobbieker
left a comment
There was a problem hiding this comment.
Thanks for this. It is very large PR, so can you split it up? Maybe one on the base, and then one for each of the Kalman, Particle, and Variational ones? Also, all of the newly added ones need to have tests in the tests folder.
Author
|
@jacobbieker sure working on it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a modular data assimilation (DA) interface designed to integrate cleanly with existing and future transformer-based models in the repository.
The motivation comes from recent research exploring how data assimilation can be incorporated into neural models to cheaply generate large ensembles of predictions, improving uncertainty handling and forecast stability. Rather than tightly coupling DA logic to a specific architecture, this PR focuses on modularity and interchangeability, ensuring that DA components can be swapped or extended without affecting core model implementations.
The added components are intentionally lightweight and model-agnostic, operating on either a graph representation or a collection of nodes, and returning outputs in the same structural format. No existing model behavior, training loops, or APIs have been modified.
Fixes #21
How Has This Been Tested?
Manual validation by integrating the new data assimilation interface with existing model outputs.
Verified that the module:
Accepts both graph-based and node-based inputs
Produces structurally consistent outputs
Does not alter existing training or inference workflows
Reproducibility
Run an existing model forward pass to generate a state or ensemble.
Pass the output through the new DA module.
Confirm the returned structure matches the input format.
Yes
Sanity Checks (Data Processing)
Performed basic consistency checks on input/output shapes and data flow.
No numerical transformations were applied that require plotting at this stage.
Yes
Checklist
My code follows OCF's coding style guidelines
I have performed a self-review of my own code
I have made corresponding changes to the documentation
I have added tests that prove my feature works (to be added in a follow-up PR)
I have checked my code and corrected any misspellings