Skip to content

Update valid times computation to make pv-only possible #346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
AUdaltsova wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Update valid times computation to make pv-only possible #346

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3b94290
update valid times to make pv-only possible
AUdaltsova Sep 11, 2025
09a838e
Merge branch 'main' into pv-only-sites
AUdaltsova Sep 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions ocf_data_sampler/torch_datasets/datasets/site.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,9 @@ def find_valid_t0_and_site_ids(
"""
# Get valid time period for nwp and satellite
datasets_without_site = {k: v for k, v in datasets_dict.items() if k != "site"}
valid_time_periods = find_valid_time_periods(datasets_without_site, self.config)

if len(datasets_without_site) > 0:
valid_time_periods = find_valid_time_periods(datasets_without_site, self.config)

# Loop over each location in system id and obtain valid periods
sites = datasets_dict["site"]
Expand All @@ -237,9 +239,13 @@ def find_valid_t0_and_site_ids(
interval_start=minutes(site_config.interval_start_minutes),
interval_end=minutes(site_config.interval_end_minutes),
)
valid_time_periods_per_site = intersection_of_multiple_dataframes_of_periods(
[valid_time_periods, time_periods],
)

if len(datasets_without_site) > 0:
valid_time_periods_per_site = intersection_of_multiple_dataframes_of_periods(
[valid_time_periods, time_periods],
)
else:
valid_time_periods_per_site = time_periods

# Fill out contiguous time periods to get t0 times
valid_t0_times_per_site = fill_time_periods(
Expand Down