Skip to content

add Primaries API#936

Merged
peterdudfield merged 8 commits intomainfrom
primaries-api
Dec 5, 2025
Merged

add Primaries API#936
peterdudfield merged 8 commits intomainfrom
primaries-api

Conversation

@peterdudfield
Copy link
Contributor

@peterdudfield peterdudfield commented Dec 4, 2025

Pull Request

Description

Add primaries API

This is for openclimatefix/quartz-api#137 but needs this to be merged first openclimatefix/quartz-api#140

How Has This Been Tested?

  • CI tests
  • test locally

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@peterdudfield peterdudfield requested a review from devsjc December 5, 2025 13:33
Copy link
Collaborator

@devsjc devsjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, my only comment is: do we want to call it the quartz API everywhere, in anticipation of it being used for uk gsp routes soon?

container-name = "quartz-api"
container-tag = var.version-primaries-api
container-registry = "ghcr.io/openclimatefix"
eb-app_name = "primaries-api"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to name this quartz-api instead? Because we might move a bunch of stuff into here and it won't just serve the primaries at that point

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm. yea, although i imagine this might be a different API deployment the to the UK one.

Perhaps I could call in quartz-api-primaries, then it shows its quartz-api and it says it for primaries

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thout you wanted to reduce the number of deployments? You can have more than one router now too - so wondering what the change of mind is to split deployments?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah ok, Lets make it general for now. Perhaps the UK National and GSP when it first goes into the quartz-api could be seperate, but then aim to get it all on one

peterdudfield and others added 3 commits December 5, 2025 13:55
Co-authored-by: devsjc <47188100+devsjc@users.noreply.github.com>
Co-authored-by: devsjc <47188100+devsjc@users.noreply.github.com>
@peterdudfield peterdudfield merged commit 4e78727 into main Dec 5, 2025
5 checks passed
@peterdudfield peterdudfield deleted the primaries-api branch December 5, 2025 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants