Fix integration tests for HuggingFace authentication Issue #187#260
Closed
mrgear111 wants to merge 2 commits intoopenclimatefix:mainfrom
Closed
Fix integration tests for HuggingFace authentication Issue #187#260mrgear111 wants to merge 2 commits intoopenclimatefix:mainfrom
mrgear111 wants to merge 2 commits intoopenclimatefix:mainfrom
Conversation
Author
|
@Sukh-P Hello sir I have tried to solve the issue.. please review it! |
Author
|
@peterdudfield Please review this PR |
Moved test utility functions from quartz_solar_forecast/eval/test_pv.py to tests/utils/hf_data_utils.py and updated all import references. This keeps test-related code in the test directory structure as suggested in PR review.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #260 +/- ##
==========================================
- Coverage 68.29% 58.98% -9.31%
==========================================
Files 27 27
Lines 1085 1085
==========================================
- Hits 741 640 -101
- Misses 344 445 +101 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
I can see that there are over 5000 files added, This makes the PR very hard to review? Could you remove some of these if not needed? |
Contributor
|
@peterdudfield i think you should close this issue as i think he committed all his virtual environment files which resulted in 5000+ files and 5 million lines of PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue where tests fail when running on the OCF GitHub due to missing HuggingFace authentication. The changes:
How Has This Been Tested?
[x] Yes
I've tested this by:
Running tests without the --run-integration flag to verify all tests pass or are properly skipped
Running tests with --run-integration to verify integration tests are attempted but skipped when HF_TOKEN is not available
Verifying that unit tests with mocked data pass correctly
Checklist:
[x] My code follows OCF's coding style guidelines
[x] I have performed a self-review of my own code
[x] I have made corresponding changes to the documentation
[x] I have added tests that prove my fix is effective or that my feature works
[x] I have checked my code and corrected any misspellings