Changed Dockerfile and pyproject.toml to fix docker build issues#269
Changed Dockerfile and pyproject.toml to fix docker build issues#269peterdudfield merged 4 commits intoopenclimatefix:mainfrom
Conversation
|
Hi @peterdudfield, I'm curious about the workflow taking approximately 20 minutes to complete. It seems the Hugging Face model download might be contributing to this duration. Perhaps implementing model caching could be beneficial for improving efficiency in the future? |
pyproject.toml
Outdated
| "pydantic_settings", | ||
| "httpx", | ||
| "sentry_sdk" | ||
| "sentry_sdk", |
There was a problem hiding this comment.
why did you do this? I think its nice to split the dependencies, then the user can select which requirements they want to install, for example pip install -e .[all] i think installs all of them
There was a problem hiding this comment.
@peterdudfield I've made the modifications to the Docker configuration and updated the pyproject.toml file according to your requirements. I've used the pip installation with the "all" tag since the API requires FastAPI and other dependencies that weren't working with the standard installation.
Lemme know anything else is required!
pyproject.toml
Outdated
| warn-unused-ignores = true | ||
| show-error-codes = true | ||
| warn-unreachable = true | ||
| warn-unreachable = true No newline at end of file |
There was a problem hiding this comment.
could you role back this change, i think it needs an extra line at the end of the file
There was a problem hiding this comment.
I think i have fixed it. Please review the changes once more!I believe I've resolved the issue. Would you kindly review the changes once more to confirm?
|
|
||
| # Install the quartz_solar_forecast package in editable mode | ||
| RUN pip install -e . | ||
| RUN pip install -e .[all] |
pyproject.toml
Outdated
| warn-unused-ignores = true | ||
| show-error-codes = true | ||
| warn-unreachable = true | ||
| warn-unreachable = true No newline at end of file |
|
Ready to merge @hrsvrn ? |
|
yep sure! |
|
@all-contributors please add @hrsvrn for infra |
1 similar comment
|
@all-contributors please add @hrsvrn for infra |
|
I've put up a pull request to add @hrsvrn! 🎉 |
2 participants
Pull Request
Description
This pull request addresses issues with the Docker build process and dependency management in the Quartz Solar Forecast project. The following changes have been made:
Modified the Dockerfile:
pip install -r requirements.txtcommandUpdated pyproject.toml:
These changes aim to resolve the Docker build failures and streamline the dependency management process.
Fixes #262
How Has This Been Tested?
I have tested these changes by:
If your changes affect data processing, have you plotted any changes? i.e. have you done a quick sanity check?
Checklist: