Skip to content

Comments

feat: Add location_type to locations.csv, introduce country metad…#165

Merged
PavanRaghavendraKulkarni merged 26 commits intomainfrom
feat/data-platform-save-fix
Feb 20, 2026
Merged

feat: Add location_type to locations.csv, introduce country metad…#165
PavanRaghavendraKulkarni merged 26 commits intomainfrom
feat/data-platform-save-fix

Conversation

@PavanRaghavendraKulkarni
Copy link
Contributor

@PavanRaghavendraKulkarni PavanRaghavendraKulkarni commented Feb 19, 2026

Pull Request

Description

This PR improves data platform location handling by:

  • Adding location_type to locations.csv

  • Introducing structured country metadata for locations

  • Implementing country-specific filtering when saving data

  • NL/BE require strict country match

  • GB allows missing country metadata (backward compatibility)

These changes improve data integrity, prevent cross-country mismatches, and support cleaner multi-country expansion.

Fixes #

How Has This Been Tested?

  • Running Locally

  • Running the Unit and Integration tests

  • Yes

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

…ata for data platform locations, implement country-specific filtering for saves, and include a GB location seeding script.
…gurations and add tests for country isolation in data platform saving.
@peterdudfield
Copy link
Contributor

Looks like the nl regional are added as national ones

Screenshot 2026-02-19 at 08 13 23

@PavanRaghavendraKulkarni PavanRaghavendraKulkarni merged commit 0182bb9 into main Feb 20, 2026
8 checks passed
@PavanRaghavendraKulkarni PavanRaghavendraKulkarni deleted the feat/data-platform-save-fix branch February 20, 2026 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants