Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR extends UUID support in the URI sanitization function from versions 1-5 to versions 1-8 (adding support for v6, v7, and v8).
- Updated UUID regex pattern to support UUID versions 6, 7, and 8
- Added comprehensive test coverage for UUID versions 1-8
- Minor shell command syntax fix in Makefile
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/Support/Uri.php | Modified UUID regex to accept versions 1-8 and relaxed variant field constraints |
| tests/Unit/Support/UriTest.php | Added test cases for UUID versions 1-8 with specific examples |
| Makefile | Fixed docker-compose command syntax for test execution |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
@copilot review |
|
@lucasdanielsx I've opened a new pull request, #9, to work on those changes. Once the pull request is ready, I'll request review from you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Adds support for the uri_mask parameter, enabling customization of masking patterns according to the specific context and requirements of the consuming service.
🔄 Type of change
✅ Checklist
feat: support UUID v6–v8 in sanitize)composer testpasses locally🔗 Related issues
UUIDs v7 are not masked.
🧩 Additional context
References: