Skip to content

Conversation

@Betree
Copy link
Member

@Betree Betree commented Jan 8, 2026

Require opencollective/opencollective-api#11348
Resolve opencollective/opencollective#4024
Resolve opencollective/opencollective#8432
Resolve opencollective/opencollective#8466
Resolve opencollective/opencollective#8467
Makes some progress for opencollective/opencollective#8470 (new contributions will have the custom payment provider name displayed).

@vercel
Copy link

vercel bot commented Jan 8, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
opencollective-frontend Ready Ready Preview, Comment Jan 30, 2026 0:10am
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
opencollective-styleguide Ignored Ignored Jan 30, 2026 0:10am

Request Review

@Betree Betree force-pushed the feat/multiple-custom-payment branch from c1e9270 to eba0cc7 Compare January 8, 2026 07:29
@Betree Betree force-pushed the feat/multiple-custom-payment branch from eba0cc7 to ccc6b81 Compare January 8, 2026 13:57
@Betree Betree force-pushed the feat/multiple-custom-payment branch from ccc6b81 to fb42286 Compare January 8, 2026 17:21
@Betree Betree force-pushed the feat/multiple-custom-payment branch from fb42286 to 367a3b9 Compare January 13, 2026 11:24
@Betree Betree force-pushed the feat/multiple-custom-payment branch from 367a3b9 to 2bad56c Compare January 13, 2026 15:06
@Betree Betree force-pushed the feat/multiple-custom-payment branch from 2bad56c to 90a8142 Compare January 14, 2026 08:59
@Betree Betree force-pushed the feat/multiple-custom-payment branch 2 times, most recently from 65cf57f to 51fac12 Compare January 15, 2026 13:46
@Betree Betree force-pushed the feat/multiple-custom-payment branch from 51fac12 to 23e36fd Compare January 22, 2026 14:08
@Betree Betree force-pushed the feat/multiple-custom-payment branch from 23e36fd to 850c8fd Compare January 22, 2026 15:23
@Betree Betree force-pushed the feat/multiple-custom-payment branch from 850c8fd to ad7f903 Compare January 22, 2026 15:52
@Betree Betree force-pushed the feat/multiple-custom-payment branch from ad7f903 to 0cbe311 Compare January 22, 2026 16:14
@Betree Betree force-pushed the feat/multiple-custom-payment branch from 0cbe311 to 332b73e Compare January 22, 2026 17:30
@Betree Betree force-pushed the feat/multiple-custom-payment branch from 332b73e to a646d75 Compare January 23, 2026 09:01
@Betree Betree force-pushed the feat/multiple-custom-payment branch from a646d75 to ba9149a Compare January 23, 2026 10:15
@Betree Betree force-pushed the feat/multiple-custom-payment branch from 2abff25 to 2e16dfd Compare January 29, 2026 11:14
@Betree Betree marked this pull request as ready for review January 29, 2026 11:15
Comment on lines -81 to -83
case ALL_SECTIONS.CONNECTED_ACCOUNTS:
return <ConnectedAccounts collective={collective} connectedAccounts={collective.connectedAccounts} />;

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The section did not exist anymore

"styled-components-migration-progress": "tsx scripts/styled-components-migration-progress.ts",
"test": "npm run test:jest",
"test:watch": "npm run test:jest -- --watch",
"test": "cross-env NODE_ENV=test TZ=UTC sh -c 'if [ $# -eq 0 ]; then jest components lib pages; else jest \"$@\"; fi' --",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To allow running npm run test test/mytest.ts

) => {
const supportedPaymentMethods = get(collective, 'host.supportedPaymentMethods', []);
const hostHasManual = supportedPaymentMethods.includes(GQLV2_SUPPORTED_PAYMENT_METHOD_TYPES.BANK_TRANSFER);
const hostHasManual = supportedPaymentMethods.includes(GQLV2_SUPPORTED_PAYMENT_METHOD_TYPES.BANK_TRANSFER); // TODO: Replace by "Manual" type
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documented a follow-up for this one in opencollective/opencollective#4040 (comment)

</div>
<div>
<p className="text-xs leading-5 font-semibold text-black">
<FormattedMessage id="PayoutMethod.Type.Paypal" defaultMessage="PayPal" />
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Service names should never be i18n

// service: stepPayment.paymentMethod.service,
// type: stepPayment.paymentMethod.type,
};
const paymentMethod = pick(stepPayment.paymentMethod, ['service', 'type', 'manualPaymentProvider']);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The API was mostly ready for this, made some last few tweaks for payment intents to be supported as well

@Betree Betree requested a review from hdiniz January 30, 2026 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants