-
-
Notifications
You must be signed in to change notification settings - Fork 436
Manual payment methods #11788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Manual payment methods #11788
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
c1e9270 to
eba0cc7
Compare
eba0cc7 to
ccc6b81
Compare
ccc6b81 to
fb42286
Compare
fb42286 to
367a3b9
Compare
367a3b9 to
2bad56c
Compare
2bad56c to
90a8142
Compare
65cf57f to
51fac12
Compare
51fac12 to
23e36fd
Compare
23e36fd to
850c8fd
Compare
850c8fd to
ad7f903
Compare
ad7f903 to
0cbe311
Compare
0cbe311 to
332b73e
Compare
332b73e to
a646d75
Compare
a646d75 to
ba9149a
Compare
866239e to
2ecd8b7
Compare
2ecd8b7 to
9f8a38d
Compare
9f8a38d to
e5a02f3
Compare
e5a02f3 to
ea211ba
Compare
ea211ba to
f634ac1
Compare
f634ac1 to
2abff25
Compare
2abff25 to
2e16dfd
Compare
| case ALL_SECTIONS.CONNECTED_ACCOUNTS: | ||
| return <ConnectedAccounts collective={collective} connectedAccounts={collective.connectedAccounts} />; | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The section did not exist anymore
| "styled-components-migration-progress": "tsx scripts/styled-components-migration-progress.ts", | ||
| "test": "npm run test:jest", | ||
| "test:watch": "npm run test:jest -- --watch", | ||
| "test": "cross-env NODE_ENV=test TZ=UTC sh -c 'if [ $# -eq 0 ]; then jest components lib pages; else jest \"$@\"; fi' --", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To allow running npm run test test/mytest.ts
| ) => { | ||
| const supportedPaymentMethods = get(collective, 'host.supportedPaymentMethods', []); | ||
| const hostHasManual = supportedPaymentMethods.includes(GQLV2_SUPPORTED_PAYMENT_METHOD_TYPES.BANK_TRANSFER); | ||
| const hostHasManual = supportedPaymentMethods.includes(GQLV2_SUPPORTED_PAYMENT_METHOD_TYPES.BANK_TRANSFER); // TODO: Replace by "Manual" type |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Documented a follow-up for this one in opencollective/opencollective#4040 (comment)
| </div> | ||
| <div> | ||
| <p className="text-xs leading-5 font-semibold text-black"> | ||
| <FormattedMessage id="PayoutMethod.Type.Paypal" defaultMessage="PayPal" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Service names should never be i18n
53e40ef to
8baa366
Compare
925173b to
4cd51ce
Compare
| // service: stepPayment.paymentMethod.service, | ||
| // type: stepPayment.paymentMethod.type, | ||
| }; | ||
| const paymentMethod = pick(stepPayment.paymentMethod, ['service', 'type', 'manualPaymentProvider']); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The API was mostly ready for this, made some last few tweaks for payment intents to be supported as well
Require opencollective/opencollective-api#11348
Resolve opencollective/opencollective#4024
Resolve opencollective/opencollective#8432
Resolve opencollective/opencollective#8466
Resolve opencollective/opencollective#8467
Makes some progress for opencollective/opencollective#8470 (new contributions will have the custom payment provider name displayed).