Skip to content

remove dataType #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 23, 2024
Merged

remove dataType #119

merged 2 commits into from
Sep 23, 2024

Conversation

@ricardo-devis-agullo
Copy link
Collaborator

@ricardo-devis-agullo ricardo-devis-agullo commented Sep 23, 2024

Remove dataType attribute, since it's not needed (it helps jquery convert to json if the server doesn't reply with the correct content-Type, but oc responds correctly), and creates a bug if parameters have double question mark as stated in their docs

In requests with dataType: "json" or dataType: "jsonp", if the string contains a double question mark (??) anywhere in the URL or a single question mark (?) in the query string, it is replaced with a value generated by jQuery that is unique for each copy of the library on the page (e.g. jQuery21406515378922229067_1479880736745).

@ricardo-devis-agullo ricardo-devis-agullo merged commit 4a44986 into master Sep 23, 2024
2 checks passed
@ricardo-devis-agullo ricardo-devis-agullo deleted the remove-datatype branch September 23, 2024 12:03
@ricardo-devis-agullo ricardo-devis-agullo mentioned this pull request Sep 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ricardo-devis-agullo