fix nested polling #141
Merged
fix nested polling #141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change refactors the polling logic in renderNestedComponent to fix race conditions and remove unnecessary delays.
Previous Behavior
The old implementation had two issues:
It added a polling delay even when a component was already rendered.
When a component was currently rendering, it would wait for one polling cycle and then stop checking. This caused rendering to fail if the component took longer to load than the polling interval.
New Behavior
The logic now explicitly handles three distinct states:
If rendered: The callback is invoked immediately.
If rendering: The function polls by recursively calling itself until rendering is complete.
If not rendered: It initiates the rendering process as before.
This new approach ensures that nested components reliably complete their rendering cycle, fixing bugs related to concurrent rendering requests.