Skip to content

Automatic management of lifecycles if supported #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ricardo-devis-agullo merged 4 commits into from
Jul 11, 2025
Merged

Automatic management of lifecycles if supported #142

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
24455ac
custom element
ricardo-devis-agullo Jul 10, 2025
bde5f64
Merge branch 'master' into custom-element
ricardo-devis-agullo Jul 10, 2025
cc56cf8
change default
ricardo-devis-agullo Jul 11, 2025
1332b13
Revert default
ricardo-devis-agullo Jul 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 48 additions & 0 deletions src/oc-client.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,9 @@ export function createOc(oc) {
let RETRY_SEND_NUMBER = ocConf.retrySendNumber || true;
let POLLING_INTERVAL = ocConf.pollingInterval || 500;
let OC_TAG = ocConf.tag || "oc-component";
let DISABLE_LIFECYCLES = isBool(ocConf.disableLifecycles)
? ocConf.disableLifecycles
: false;
let MESSAGES_ERRORS_HREF_MISSING = "Href parameter missing";
let MESSAGES_ERRORS_RETRY_FAILED =
"Failed to load % component " + RETRY_LIMIT + " times. Giving up";
Expand Down Expand Up @@ -670,5 +673,50 @@ export function createOc(oc) {
// render the components
loadAfterReady();

if (window.customElements) {
window.customElements.define(
OC_TAG,
class extends HTMLElement {
#connected = false;
#manageLifecycle = !DISABLE_LIFECYCLES;
// biome-ignore lint/complexity/noUselessConstructor: <explanation>
constructor() {
super();
}

connectedCallback() {
this.#connected = true;

if (
this.getAttribute("disable-lifecycle") == "true" ||
this.getAttribute("disable-lifecycle") == ""
) {
this.#manageLifecycle = false;
} else if (this.getAttribute("disable-lifecycle") == "false") {
this.#manageLifecycle = true;
}

if (this.#manageLifecycle) {
oc.renderNestedComponent(this, () => {});
}
}

disconnectedCallback() {
if (this.#connected) {
this.#connected = false;
const shouldUnmount =
this.#manageLifecycle &&
this.unmount &&
this.getAttribute("data-rendered") == "true";
if (shouldUnmount) {
this.unmount();
this.removeAttribute("data-rendered");
}
}
}
},
);
}

return oc;
}