Skip to content

fix log by not passing data #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 8, 2025
Merged

fix log by not passing data #151

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
657f949
fix log by not passing data
ricardo-devis-agullo Sep 8, 2025
1227972
pass tests
ricardo-devis-agullo Sep 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/oc-client.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -382,9 +382,7 @@ export function createOc(oc) {

return {
fire(key, data) {
logInfo(
`OC event fired: "${key}"${data ? ` with data: ${JSON.stringify(data)}` : ""}`,
);
logInfo(`OC event fired: "${key}"`);
if (listeners[key]) {
for (let cb of listeners[key]) {
cb({ type: key }, data);
Expand Down
8 changes: 2 additions & 6 deletions tests/events.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,13 +248,9 @@ test.describe("oc-client : events", () => {

expect(result.logCallCount).toBe(3);

expect(result.logCalls[0][0]).toBe(
'OC event fired: "trace:test1" with data: {"message":"hello"}',
);
expect(result.logCalls[0][0]).toBe('OC event fired: "trace:test1"');

expect(result.logCalls[1][0]).toBe(
'OC event fired: "trace:test2" with data: {"count":42}',
);
expect(result.logCalls[1][0]).toBe('OC event fired: "trace:test2"');

expect(result.logCalls[2][0]).toBe('OC event fired: "trace:test3"');
});
Expand Down