move registrycli type to its file

Author: ricardo-devis-agullo

src/cli/domain/registry.ts

@@ -7,7 +7,7 @@ import put from '../../utils/put';
 import settings from '../../resources/settings';
 import * as urlBuilder from '../../registry/domain/url-builder';
 import * as urlParser from '../domain/url-parser';
-import { RegistryCli } from '../../types';
+import { Component } from '../../types';
 
 const getOcVersion = (): string => {
   const ocPackagePath = path.join(__dirname, '../../../package.json');
@@ -20,15 +20,15 @@ interface RegistryOptions {
   registry?: string;
 }
 
-export default function registry(opts: RegistryOptions = {}): RegistryCli {
+export default function registry(opts: RegistryOptions = {}) {
   let requestsHeaders = {
     'user-agent': `oc-cli-${getOcVersion()}/${process.version}-${
       process.platform
     }-${process.arch}`
   };
 
   return {
-    async add(registry: string) {
+    async add(registry: string): Promise<void> {
       if (registry.slice(registry.length - 1) !== '/') {
         registry += '/';
       }
@@ -57,7 +57,7 @@ export default function registry(opts: RegistryOptions = {}): RegistryCli {
         throw 'oc registry not available';
       }
     },
-    async get() {
+    async get(): Promise<string[]> {
       if (opts.registry) {
         return [opts.registry];
       }
@@ -73,12 +73,12 @@ export default function registry(opts: RegistryOptions = {}): RegistryCli {
         throw 'No oc registries';
       }
     },
-    getApiComponentByHref(href: string) {
+    getApiComponentByHref(href: string): Promise<Component> {
       return got(href + settings.registry.componentInfoPath, {
         headers: requestsHeaders
       }).json();
     },
-    async getComponentPreviewUrlByUrl(componentHref: string) {
+    async getComponentPreviewUrlByUrl(componentHref: string): Promise<string> {
       const res: { requestVersion: string; href: string } = await got(
         componentHref,
         { headers: requestsHeaders }
@@ -93,7 +93,7 @@ export default function registry(opts: RegistryOptions = {}): RegistryCli {
       password?: string;
       route: string;
       path: string;
-    }) {
+    }): Promise<void> {
       if (!!options.username && !!options.password) {
         requestsHeaders = Object.assign(requestsHeaders, {
           Authorization:
@@ -129,7 +129,7 @@ export default function registry(opts: RegistryOptions = {}): RegistryCli {
         throw errMsg;
       }
     },
-    async remove(registry: string) {
+    async remove(registry: string): Promise<void> {
       if (registry.slice(registry.length - 1) !== '/') {
         registry += '/';
       }
@@ -143,3 +143,5 @@ export default function registry(opts: RegistryOptions = {}): RegistryCli {
     }
   };
 }
+
+export type RegistryCli = ReturnType<typeof registry>;

src/cli/facade/preview.ts

@@ -2,7 +2,7 @@ import open from 'open';
 import { fromPromise } from 'universalify';
 
 import strings from '../../resources/index';
-import { RegistryCli } from '../../types';
+import { RegistryCli } from '../domain/registry';
 import { Logger } from '../logger';
 
 const preview = ({

src/cli/facade/publish.ts

@@ -5,11 +5,12 @@ import readCb from 'read';
 import { promisify } from 'util';
 import { Logger } from '../logger';
 import type { Local } from '../domain/local';
-import { Component, RegistryCli } from '../../types';
+import { Component } from '../../types';
 import { fromPromise } from 'universalify';
 
 import handleDependencies from '../domain/handle-dependencies';
 import strings from '../../resources/index';
+import { RegistryCli } from '../domain/registry';
 
 const read = promisify(readCb);
 

src/cli/facade/registry-add.ts

@@ -1,6 +1,6 @@
 import { fromPromise } from 'universalify';
 import strings from '../../resources/index';
-import { RegistryCli } from '../../types';
+import { RegistryCli } from '../domain/registry';
 import { Logger } from '../logger';
 
 const registryAdd = ({

src/cli/facade/registry-ls.ts

@@ -1,7 +1,7 @@
 import { fromPromise } from 'universalify';
 
 import strings from '../../resources/index';
-import { RegistryCli } from '../../types';
+import { RegistryCli } from '../domain/registry';
 import { Logger } from '../logger';
 
 const registryLs = ({

src/cli/facade/registry-remove.ts

@@ -1,6 +1,6 @@
 import { fromPromise } from 'universalify';
 import strings from '../../resources/index';
-import { RegistryCli } from '../../types';
+import { RegistryCli } from '../domain/registry';
 import { Logger } from '../logger';
 
 const registryRemove = ({

src/cli/programmatic-api.ts

@@ -1,6 +1,6 @@
 import local, { Local } from './domain/local';
 import { Logger } from './logger';
-import Registry from './domain/registry';
+import Registry, { RegistryCli } from './domain/registry';
 
 import dev from './facade/dev';
 import init from './facade/init';
@@ -11,7 +11,6 @@ import preview from './facade/preview';
 import registryAdd from './facade/registry-add';
 import registryLs from './facade/registry-ls';
 import registryRemove from './facade/registry-remove';
-import { RegistryCli } from '../types';
 
 type Options<T extends (...args: any) => any> = Parameters<ReturnType<T>>[0];
 type Cb<T extends (...args: any) => any> = Parameters<ReturnType<T>>[1];

src/types.ts

@@ -235,20 +235,6 @@ export interface Plugin {
   };
 }
 
-export interface RegistryCli {
-  add(registry: string): Promise<void>;
-  get(): Promise<string[]>;
-  getApiComponentByHref(href: string): Promise<Component>;
-  getComponentPreviewUrlByUrl(componentHref: string): Promise<string>;
-  putComponent(options: {
-    username?: string;
-    password?: string;
-    route: string;
-    path: string;
-  }): Promise<void>;
-  remove(registry: string): Promise<void>;
-}
-
 declare global {
   // eslint-disable-next-line @typescript-eslint/no-namespace
   namespace Express {