Merge pull request #1301 from opencomponents/tarmode

add tarExtractMode for extracting packages

Author: ricardo-devis-agullo

src/registry/domain/extract-package.ts

@@ -10,7 +10,8 @@ export default async function extractPackage(
     | Express.Multer.File[]
     | {
         [fieldname: string]: Express.Multer.File[];
-      }
+      },
+  tarExtractMode: number
 ): Promise<{
   outputFolder: string;
   packageJson: PackageJson;
@@ -28,7 +29,11 @@ export default async function extractPackage(
 
   await decompress({
     src: packagePath,
-    dest: packageUntarOutput
+    dest: packageUntarOutput,
+    tar: {
+      dmode: tarExtractMode,
+      fmode: tarExtractMode
+    }
   });
 
   const packageJson = await getPackageJsonFromTempDir(packageOutput);

src/registry/domain/options-sanitiser.ts

@@ -60,6 +60,10 @@ export default function optionsSanitiser(input: Input): Config {
     options.dependencies = [];
   }
 
+  if (typeof options.tarExtractMode === 'undefined') {
+    options.tarExtractMode = 766;
+  }
+
   if (
     typeof options.fallbackRegistryUrl !== 'undefined' &&
     !options.fallbackRegistryUrl.endsWith('/')

src/registry/routes/publish.ts

@@ -54,7 +54,7 @@ export default function publish(repository: Repository) {
     }
 
     try {
-      const pkgDetails = await extractPackage(files);
+      const pkgDetails = await extractPackage(files, res.conf.tarExtractMode);
 
       try {
         await repository.publishComponent(

src/types.ts

@@ -155,6 +155,7 @@ export interface Config {
   liveReloadPort: number;
   components?: string[];
   local: boolean;
+  tarExtractMode: number;
   path: string;
   plugins: Record<string, (...args: unknown[]) => void>;
   pollingInterval: number;

test/unit/registry-domain-extract-package.js

@@ -36,20 +36,27 @@ describe('registry : domain : extract-package', () => {
 
       decompressStub.yields();
 
-      extractPackage([
-        {
-          filename: '1478279453422.tar.gz',
-          path: '/some-path/registry/temp/1478279453422.tar.gz'
-        }
-      ])
+      extractPackage(
+        [
+          {
+            filename: '1478279453422.tar.gz',
+            path: '/some-path/registry/temp/1478279453422.tar.gz'
+          }
+        ],
+        766
+      )
         .then(res => (response = res))
         .finally(done);
     });
 
     it('should decompress tar.gz file', () => {
       expect(decompressStub.args[0][0]).to.eql({
         src: '/some-path/registry/temp/1478279453422.tar.gz',
-        dest: '/some-path/registry/temp/1478279453422/'
+        dest: '/some-path/registry/temp/1478279453422/',
+        tar: {
+          dmode: 766,
+          fmode: 766
+        }
       });
     });
 
@@ -78,12 +85,15 @@ describe('registry : domain : extract-package', () => {
 
       decompressStub.yields('error!');
 
-      extractPackage([
-        {
-          filename: '1478279453422.tar.gz',
-          path: '/some-path/registry/temp/1478279453422.tar.gz'
-        }
-      ])
+      extractPackage(
+        [
+          {
+            filename: '1478279453422.tar.gz',
+            path: '/some-path/registry/temp/1478279453422.tar.gz'
+          }
+        ],
+        766
+      )
         .catch(err => (error = err))
         .finally(done);
     });