merge master

Author: ricardo-devis-agullo

package-lock.json

@@ -39,10 +39,9 @@ const dev = ({ local, logger }: { logger: Logger; local: Local }) =>
       const port = opts.port || 3000;
       const baseUrl = opts.baseUrl || `http://localhost:${port}/`;
       const fallbackRegistryUrl = opts.fallbackRegistryUrl;
-      const hotReloading = _.isUndefined(opts.hotReloading)
-        ? true
-        : opts.hotReloading;
-      const optWatch = _.isUndefined(opts.watch) ? true : opts.watch;
+      const hotReloading =
+        typeof opts.hotReloading === 'undefined' ? true : opts.hotReloading;
+      const optWatch = typeof opts.watch === 'undefined' ? true : opts.watch;
       let packaging = false;
 
       const watchForChanges = function (

src/cli/facade/dev.ts

@@ -37,28 +37,28 @@ export default function optionsSanitiser(input: Input): Config {
     options.tempDir = settings.registry.defaultTempPath;
   }
 
-  if (!_.isBoolean(options.hotReloading)) {
+  if (typeof options.hotReloading !== 'boolean') {
     options.hotReloading = !!options.local;
   }
 
-  if (_.isUndefined(options.verbosity)) {
+  if (!options.verbosity) {
     options.verbosity = 0;
   }
 
-  if (_.isUndefined(options.discovery)) {
+  if (typeof options.discovery === 'undefined') {
     options.discovery = true;
   }
 
-  if (_.isUndefined(options.pollingInterval)) {
+  if (typeof options.pollingInterval === 'undefined') {
     options.pollingInterval = 5;
   }
 
-  if (_.isUndefined(options.templates)) {
+  if (!options.templates) {
     options.templates = [];
   }
 
   if (
-    !_.isUndefined(options.fallbackRegistryUrl) &&
+    typeof options.fallbackRegistryUrl !== 'undefined' &&
     _.last(options.fallbackRegistryUrl) !== '/'
   ) {
     options.fallbackRegistryUrl += '/';

src/registry/domain/options-sanitiser.ts

@@ -12,9 +12,9 @@ function validatePlugins(plugins: unknown[]): asserts plugins is Plugin[] {
     c++;
     if (
       !_.isObject((plugin as Plugin).register) ||
-      !_.isFunction((plugin as Plugin).register.register) ||
-      !_.isFunction((plugin as Plugin).register.execute) ||
-      !_.isString((plugin as Plugin).name)
+      typeof (plugin as Plugin).register.register !== 'function' ||
+      typeof (plugin as Plugin).register.execute !== 'function' ||
+      typeof (plugin as Plugin).name !== 'string'
     ) {
       throw new Error(
         strings.errors.registry.PLUGIN_NOT_VALID(

src/registry/domain/plugins-initialiser.ts

@@ -129,16 +129,14 @@ export default function repository(conf: Config): Repository {
       componentVersionOrCallback: string | Callback<Component, string>,
       callbackMaybe?: Callback<Component, string>
     ) {
-      const componentVersion: string | undefined = _.isFunction(
-        componentVersionOrCallback
-      )
-        ? undefined
-        : (componentVersionOrCallback as any);
-      const callback: Callback<Component, string> = _.isFunction(
-        componentVersionOrCallback
-      )
-        ? (componentVersionOrCallback as any)
-        : callbackMaybe!;
+      const componentVersion: string | undefined =
+        typeof componentVersionOrCallback === 'function'
+          ? undefined
+          : (componentVersionOrCallback as any);
+      const callback: Callback<Component, string> =
+        typeof componentVersionOrCallback === 'function'
+          ? (componentVersionOrCallback as any)
+          : callbackMaybe!;
 
       fromPromise(repository.getComponentVersions)(
         componentName,

src/registry/domain/repository.ts

@@ -44,7 +44,7 @@ export default function components(
       return returnError(
         registryErrors.BATCH_ROUTE_COMPONENTS_PROPERTY_MISSING
       );
-    } else if (!_.isArray(components)) {
+    } else if (!Array.isArray(components)) {
       return returnError(registryErrors.BATCH_ROUTE_COMPONENTS_NOT_ARRAY);
     }
 

src/registry/routes/components.ts

@@ -12,7 +12,7 @@ describe('registry : routes : helpers : nested-renderer', () => {
   let renderer;
 
   const initialise = function (rendererMocks, conf) {
-    if (_.isArray(rendererMocks)) {
+    if (Array.isArray(rendererMocks)) {
       renderer = sinon.stub();
 
       _.each(rendererMocks, (rendererMock, i) => {