add more tests

Author: ricardo-devis-agullo

src/registry/domain/components-cache/components-list.ts

@@ -58,7 +58,7 @@ export default function componentsList(conf: Config, cdn: StorageAdapter) {
 
         if (invalidVersions.length > 0) {
           eventsHandler.fire('error', {
-            code: 'CORRUPTED_VERSION',
+            code: 'corrupted_version',
             message: `Couldn't validate the integrity of the component ${componentName} on the following versions: ${invalidVersions.join(
               ', '
             )}.`

test/unit/registry-domain-components-cache.js

@@ -45,7 +45,8 @@ describe('registry : domain : components-cache', () => {
         './components-list': injectr(
           '../../dist/registry/domain/components-cache/components-list.js',
           {
-            'oc-get-unix-utc-timestamp': getTimestamp
+            'oc-get-unix-utc-timestamp': getTimestamp,
+            '../events-handler': eventsHandlerStub
           }
         ).default
       },
@@ -63,7 +64,7 @@ describe('registry : domain : components-cache', () => {
       let error;
       before(done => {
         mockedCdn.getJson = sinon.stub();
-        mockedCdn.getJson.rejects('FILE_ERROR');
+        mockedCdn.getJson.rejects(new Error('FILE_ERROR'));
         initialise();
         componentsCache
           .load()
@@ -72,7 +73,7 @@ describe('registry : domain : components-cache', () => {
       });
 
       it('should throw with the error message', () => {
-        expect(error).to.equal('FILE_ERROR');
+        expect(error.message).to.equal('FILE_ERROR');
       });
     });
     describe('when initialising the cache', () => {
@@ -129,25 +130,46 @@ describe('registry : domain : components-cache', () => {
       before(done => {
         mockedCdn.getJson = sinon.stub();
         mockedCdn.getJson.resolves(baseResponse());
+        mockedCdn.getJson
+          .withArgs('component/hello-world/3.0.0/package.json')
+          .rejects('ERROR');
         mockedCdn.listSubDirectories = sinon.stub();
         mockedCdn.listSubDirectories.onCall(0).resolves(['hello-world']);
         mockedCdn.listSubDirectories
           .onCall(1)
-          .resolves(['1.0.0', '1.0.2', '2.0.0']);
+          .resolves(['1.0.0', '1.0.2', '2.0.0', '3.0.0']);
         mockedCdn.putFileContent = sinon.stub();
         mockedCdn.putFileContent.resolves('ok');
         initialise();
         componentsCache.load().finally(done);
       });
 
       it('should fetch the components.json', () => {
-        expect(mockedCdn.getJson.calledTwice).to.be.true;
         expect(mockedCdn.getJson.args[0][0]).to.be.equal(
           'component/components.json'
         );
+      });
+
+      it('should verify new versions', () => {
+        expect(mockedCdn.getJson.calledThrice).to.be.true;
         expect(mockedCdn.getJson.args[1][0]).to.be.equal(
           'component/hello-world/2.0.0/package.json'
         );
+        expect(mockedCdn.getJson.args[2][0]).to.be.equal(
+          'component/hello-world/3.0.0/package.json'
+        );
+      });
+
+      it('should ignore corrupted versions and generate an error event', () => {
+        expect(eventsHandlerStub.fire.called).to.be.true;
+        expect(eventsHandlerStub.fire.args[0][0]).to.equal('error');
+        expect(eventsHandlerStub.fire.args[0][1].code).to.equal(
+          'corrupted_version'
+        );
+        expect(eventsHandlerStub.fire.args[0][1].message).to.contain(
+          'hello-world'
+        );
+        expect(eventsHandlerStub.fire.args[0][1].message).to.contain('3.0.0');
       });
 
       it('should scan for directories to fetch components and versions', () => {