reduce lodash functions where they are easy replaceable

ricardo-devis-agullo · ricardo-devis-agullo · commit d7271560d3cd · 2021-10-13T23:13:03.000+02:00
diff --git a/src/cli/facade/registry-ls.ts b/src/cli/facade/registry-ls.ts
@@ -1,5 +1,3 @@
-import _ from 'lodash';
-
 import strings from '../../resources/index';
 import { RegistryCli } from '../../types';
 import { Logger } from '../logger';
@@ -20,7 +18,7 @@ const registryLs =
           return callback(err, undefined as any);
         }
 
-        _.forEach(registries, registryLocation => logger.ok(registryLocation));
+        registries.forEach(registryLocation => logger.ok(registryLocation));
 
         callback(null, registries);
       }
diff --git a/src/cli/index.ts b/src/cli/index.ts
@@ -95,7 +95,7 @@ function processCommand(
   );
 }
 
-_.forEach(commands.commands, (command, commandName) => {
+Object.entries(commands.commands).forEach(([commandName, command]) => {
   processCommand(command, commandName, cli);
 });
 
diff --git a/src/cli/programmatic-api.ts b/src/cli/programmatic-api.ts
@@ -1,4 +1,3 @@
-import _ from 'lodash';
 import local from './domain/local';
 import { Logger } from './logger';
 import Registry from './domain/registry';
@@ -44,95 +43,101 @@ function getDeps(options: {
 
 export default {
   dev: (
-    options: Options<typeof dev> & { logger: Logger },
+    { logger, ...options }: Options<typeof dev> & { logger: Logger },
     cb: Cb<typeof dev>
   ): void => {
-    const deps = getDeps({ logger: options.logger });
-    const opts = _.omit(options, 'logger');
+    const deps = getDeps({ logger });
 
-    dev(deps)(opts, cb);
+    dev(deps)(options, cb);
   },
   init: (
-    options: Options<typeof init> & { logger: Logger },
+    { logger, ...options }: Options<typeof init> & { logger: Logger },
     cb: Cb<typeof init>
   ): void => {
-    const deps = getDeps({ logger: options.logger });
-    const opts = _.omit(options, 'logger');
+    const deps = getDeps({ logger });
 
-    init(deps)(opts, cb);
+    init(deps)(options, cb);
   },
   mock: (
-    options: Options<typeof mock> & { logger: Logger },
+    { logger, ...options }: Options<typeof mock> & { logger: Logger },
     cb: Cb<typeof mock>
   ): void => {
-    const deps = getDeps({ logger: options.logger });
-    const opts = _.omit(options, 'logger');
+    const deps = getDeps({ logger });
 
-    mock(deps)(opts, cb);
+    mock(deps)(options, cb);
   },
   package: (
-    options: Options<typeof packageScript> & { logger: Logger },
+    { logger, ...options }: Options<typeof packageScript> & { logger: Logger },
     cb: Cb<typeof packageScript>
   ): void => {
-    const deps = getDeps({ logger: options.logger });
-    const opts = _.omit(options, 'logger');
+    const deps = getDeps({ logger });
 
-    packageScript(deps)(opts, cb);
+    packageScript(deps)(options, cb);
   },
   publish: (
-    options: Options<typeof publish> & { logger: Logger; registry?: string },
+    {
+      logger,
+      ...options
+    }: Options<typeof publish> & { logger: Logger; registry?: string },
     cb: Cb<typeof publish>
   ): void => {
-    const deps = getDeps({ logger: options.logger, withRegistry: true });
-    const opts = _.omit(options, 'logger');
+    const deps = getDeps({ logger, withRegistry: true });
 
-    publish(deps)(opts, cb);
+    publish(deps)(options, cb);
   },
   preview: (
-    options: Options<typeof preview> & { logger: Logger; registry?: string },
+    {
+      logger,
+      ...options
+    }: Options<typeof preview> & { logger: Logger; registry?: string },
     cb: Cb<typeof preview>
   ): void => {
-    const deps = getDeps({ logger: options.logger, withRegistry: true });
-    const opts = _.omit(options, 'logger');
+    const deps = getDeps({ logger, withRegistry: true });
 
-    preview(deps)(opts, cb);
+    preview(deps)(options, cb);
   },
   registry: {
     add: (
-      options: Options<typeof registryAdd> & {
+      {
+        logger,
+        ...options
+      }: Options<typeof registryAdd> & {
         logger: Logger;
         registry?: string;
       },
       cb: Cb<typeof registryAdd>
     ): void => {
-      const deps = getDeps({ logger: options.logger, withRegistry: true });
-      const opts = _.omit(options, 'logger');
+      const deps = getDeps({ logger, withRegistry: true });
 
-      registryAdd(deps)(opts, cb);
+      registryAdd(deps)(options, cb);
     },
     ls: (
-      options: Options<typeof registryLs> & {
+      {
+        logger,
+        ...options
+      }: Options<typeof registryLs> & {
         logger: Logger;
         registry?: string;
       },
       cb: Cb<typeof registryLs>
     ): void => {
-      const deps = getDeps({ logger: options.logger, withRegistry: true });
-      const opts = _.omit(options, 'logger');
+      const deps = getDeps({ logger, withRegistry: true });
 
-      registryLs(deps)(opts, cb);
+      registryLs(deps)(options, cb);
     },
     remove: (
-      options: Options<typeof registryRemove> & {
+      {
+        logger,
+        ...options
+      }: Options<typeof registryRemove> & {
         logger: Logger;
         registry?: string;
       },
       cb: Cb<typeof registryRemove>
     ): void => {
-      const deps = getDeps({ logger: options.logger, withRegistry: true });
-      const opts = _.omit(options, 'logger');
+      const deps = getDeps({ logger, withRegistry: true });
 
-      registryRemove(deps)(opts, cb);
+      registryRemove(deps)(options, cb);
     }
   }
 };
diff --git a/src/registry/domain/components-details.ts b/src/registry/domain/components-details.ts
@@ -30,7 +30,7 @@ export default function componentsDetails(conf: Config, cdn: Cdn) {
     options: { componentsList: ComponentsList; details: ComponentsDetails },
     callback: Callback<ComponentsDetails, Error | undefined>
   ) => {
-    const details = _.extend({}, _.cloneDeep(options.details));
+    const details = Object.assign({}, _.cloneDeep(options.details));
     details.components = details.components || {};
 
     const missing: Array<{ name: string; version: string }> = [];
diff --git a/src/registry/domain/require-wrapper.ts b/src/registry/domain/require-wrapper.ts
@@ -6,7 +6,7 @@ import _ from 'lodash';
 
 import strings from '../../resources';
 
-const isCoreDependency = (x: string) => _.includes(coreModules, x);
+const isCoreDependency = (x: string) => coreModules.includes(x);
 const requireCoreDependency = (x: string) =>
   (isCoreDependency(x) && tryRequire(x)) || undefined;
 
diff --git a/src/registry/index.ts b/src/registry/index.ts
@@ -42,15 +42,15 @@ export default function registry(inputOptions: Input) {
     plugin: Omit<Plugin, 'callback'>,
     callback?: (...args: any[]) => void
   ) => {
-    plugins.push(_.extend(plugin, { callback }));
+    plugins.push(Object.assign(plugin, { callback }));
   };
 
   const start = (
     callback: Callback<{ app: express.Express; server: http.Server }>
   ) => {
     // eslint-disable-next-line no-console
     const ok = (msg: string) => console.log(colors.green(msg));
-    if (!_.isFunction(callback)) {
+    if (typeof callback !== 'function') {
       callback = _.noop;
     }
     router.create(app, options, repository);
diff --git a/src/registry/router.ts b/src/registry/router.ts
@@ -1,5 +1,3 @@
-import _ from 'lodash';
-
 import ComponentRoute from './routes/component';
 import ComponentsRoute from './routes/components';
 import ComponentInfoRoute from './routes/component-info';
@@ -81,7 +79,7 @@ export function create(
   app.get(`${prefix}:componentName`, routes.component);
 
   if (conf.routes) {
-    _.forEach(conf.routes, route =>
+    conf.routes.forEach(route =>
       app[
         route.method.toLowerCase() as 'get' | 'post' | 'put' | 'patch' | 'head'
       ](route.route, route.handler)
diff --git a/src/registry/routes/component-info.ts b/src/registry/routes/component-info.ts
@@ -82,7 +82,7 @@ function componentInfo(
     });
   } else {
     res.status(200).json(
-      _.extend(component, {
+      Object.assign(component, {
         requestVersion: req.params.componentVersion || ''
       })
     );
diff --git a/src/registry/routes/component-preview.ts b/src/registry/routes/component-preview.ts
@@ -1,5 +1,3 @@
-import _ from 'lodash';
-
 import * as getComponentFallback from './helpers/get-component-fallback';
 import previewView from '../views/preview';
 import * as urlBuilder from '../domain/url-builder';
@@ -39,7 +37,7 @@ function componentPreview(
     );
   } else {
     res.status(200).json(
-      _.extend(component, {
+      Object.assign(component, {
         requestVersion: req.params.componentVersion || ''
       })
     );
diff --git a/src/registry/routes/helpers/get-component.ts b/src/registry/routes/helpers/get-component.ts
@@ -79,7 +79,7 @@ export default function getComponent(conf: Config, repository: Repository) {
 
       retrievingInfo.extend({ status: result.status });
 
-      _.extend(result.response, {
+      Object.assign(result.response, {
         name: options.name,
         requestVersion: options.version || ''
       });
diff --git a/src/registry/routes/index.ts b/src/registry/routes/index.ts
@@ -24,7 +24,7 @@ const getParsedAuthor = (author?: Author | string): Author => {
 };
 
 const mapComponentDetails = (component: Component): ParsedComponent =>
-  _.extend(component, { author: getParsedAuthor(component.author) });
+  Object.assign(component, { author: getParsedAuthor(component.author) });
 
 const isHtmlRequest = (headers: IncomingHttpHeaders) =>
   !!headers.accept && headers.accept.indexOf('text/html') >= 0;
@@ -74,14 +74,14 @@ export default function (repository: Repository) {
               res.send(
                 indexView(
                   // @ts-ignore
-                  _.extend(baseResponse, {
+                  Object.assign(baseResponse, {
                     availableDependencies: getAvailableDependencies(
                       res.conf.dependencies
                     ),
                     availablePlugins: res.conf.plugins,
                     components: componentsInfo,
                     componentsReleases,
-                    componentsList: _.map(componentsInfo, component => {
+                    componentsList: componentsInfo.map(component => {
                       const state: 'deprecated' | 'experimental' | undefined =
                         _.get(component, 'oc.state', '');
                       if (state) {
@@ -108,7 +108,7 @@ export default function (repository: Repository) {
         );
       } else {
         res.status(200).json(
-          _.extend(baseResponse, {
+          Object.assign(baseResponse, {
             components: _.map(components, component =>
               urlBuilder.component(component, res.conf.baseUrl)
             )

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,3 @@`
`1`		`-import _ from 'lodash';`
`2`		`-`
`3`	`1`	`import strings from '../../resources/index';`
`4`	`2`	`import { RegistryCli } from '../../types';`
`5`	`3`	`import { Logger } from '../logger';`
`@@ -20,7 +18,7 @@ const registryLs =`
`20`	`18`	`return callback(err, undefined as any);`
`21`	`19`	`}`
`22`	`20`
`23`		`- _.forEach(registries, registryLocation => logger.ok(registryLocation));`
	`21`	`+ registries.forEach(registryLocation => logger.ok(registryLocation));`
`24`	`22`
`25`	`23`	`callback(null, registries);`
`26`	`24`	`}`
Original file line number	Diff line number	Diff line change
`@@ -95,7 +95,7 @@ function processCommand(`
`95`	`95`	`);`
`96`	`96`	`}`
`97`	`97`
`98`		`-_.forEach(commands.commands, (command, commandName) => {`
	`98`	`+Object.entries(commands.commands).forEach(([commandName, command]) => {`
`99`	`99`	`processCommand(command, commandName, cli);`
`100`	`100`	`});`
`101`	`101`