Fix instructions for Signed-off-by in commits #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evan-a-a
force-pushed
the
fix_signing_instructions
branch
2 times, most recently
from
bade007 to
fb0fd1c
Compare
--signoff appends "Signed-off-by" to the commit. Signed-off-by: Evan Anderson <[email protected]>
evan-a-a
force-pushed
the
fix_signing_instructions
branch
from
fb0fd1c to
1ef3c86
Compare
evan-a-a
changed the title
Contributor
Author
|
The link included here was to the Signed commit instructions, i.e. with a GPG or SSH key, but the note discussed the DCO functionality "Signed-off-by". As far as I can tell, the actual implementation solely requires the DCO, so I updated the docs to reflect this. If indeed signed commits are also required, the repository should be configured for this, and I can fix the PR to reflect that. |
ericeilertson
approved these changes
Dec 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--signoff appends "Signed-off-by" to the commit.