Skip to content

Conversation

@vivekrnv
Copy link
Contributor

@vivekrnv vivekrnv commented Jan 6, 2026

  1. Instead of relying on Doxygen version, detect XML structure
  2. Clean up the code
vkarri@787cb73f7e41:/sonic/src/sonic-sairedis/SAI/meta$ cat /etc/os-release
PRETTY_NAME="Debian GNU/Linux trixie/sid"
NAME="Debian GNU/Linux"
VERSION_CODENAME=trixie
ID=debian
HOME_URL="https://www.debian.org/"
SUPPORT_URL="https://www.debian.org/support"
BUG_REPORT_URL="https://bugs.debian.org/"

Verified in Trixie environment

vkarri@787cb73f7e41:/sonic/src/sonic-sairedis/SAI/meta$ make
GNU Make 4.4.1
gcc (Debian 14.2.0-19) 14.2.0
This is perl 5, version 40, subversion 1 (v5.40.1) built for x86_64-linux-gnu-thread-multi
@(#) International Ispell Version 3.1.20 (but really Aspell 0.60.8.1)
dot - graphviz version 2.42.4 (0)
doxygen: 1.9.8
GNU nm (GNU Binutils for Debian) 2.44
doxygen Doxyfile 2>&1 | perl -npe '$e=1 if /warning/i; END{exit $e}'
touch xml
./attrversion.sh
perl -I. parse.pl
Processing capability file sample.cap
Skipping cap file sample.cap
Running Aspell
Words to check: 3445
New XML structure detected, proceeding with 2 pass processing
./saimetadatatest >/dev/null
saimetadata.c:181571 sai_serialize_health_data: :- nothing was serialized for 'sai_health_data_t', bad condition?
saimetadata.c:181571 sai_serialize_health_data: :- nothing was serialized for 'sai_health_data_t', bad condition?
./saiserializetest >/dev/null
./saisanitycheck
WARN: enum sai_port_attr_extensions_t has no values
WARN: sai_api_extensions_t: contains extensions range attributes
WARN: sai_api_t: contains extensions range attributes
WARN: sai_object_type_extensions_t: contains extensions range attributes
WARN: sai_object_type_t: contains extensions range attributes
WARN: sai_port_stat_extensions_t: contains extensions range attributes
WARN: sai_port_stat_t: contains extensions range attributes
WARN: sai_switch_attr_extensions_t: contains extensions range attributes
WARN: sai_switch_attr_t: contains extensions range attributes
WARN: condition relaxed on: SAI_TUNNEL_TERM_TABLE_ENTRY_ATTR_DST_IP
WARN: condition relaxed on: SAI_TUNNEL_TERM_TABLE_ENTRY_ATTR_SRC_IP
WARN: object SAI_OBJECT_TYPE_STP has only READ_ONLY attributes
WARN: object SAI_OBJECT_TYPE_RPF_GROUP has only READ_ONLY attributes
WARN: object SAI_OBJECT_TYPE_L2MC_GROUP has only READ_ONLY attributes
WARN: debug counter object SAI_OBJECT_TYPE_DEBUG_COUNTER is disconnected from graph
WARN: experimental object SAI_OBJECT_TYPE_FLOW_ENTRY_BULK_GET_SESSION_FILTER is disconnected from graph
WARN: experimental object SAI_OBJECT_TYPE_FLOW_ENTRY_BULK_GET_SESSION is disconnected from graph
WARN: experimental object SAI_OBJECT_TYPE_DASH_APPLIANCE is disconnected from graph
WARN: debug counter object SAI_OBJECT_TYPE_DEBUG_COUNTER not present on any object list (eg. VLAN_MEMBER is present on SAI_VLAN_ATTR_MEMBER_LIST)
INFO: SAI_OBJECT_TYPE_MAX = 115, EXTENSION_OBJECT_TYPE_COUNT = 32, CUSTOM_OBJECT_TYPE_COUNT = 0

 [ SAI_STATUS_SUCCESS ]

@vivekrnv
Copy link
Contributor Author

vivekrnv commented Jan 6, 2026

@tjchadaga, @saiarcot895, @kcudnik comments for #2239 handled. Please review

meta/parse.pl Outdated

for my $section (@sai_sections)
{
if ($section->{kind} eq "enum")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can reduce idene makint this

next if $section->{kind} ne "enum"; 

similar like in line 5342

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Handled

@kcudnik
Copy link
Collaborator

kcudnik commented Jan 6, 2026

this change is much more clean and readable, thanks @vivekrnv

Signed-off-by: Vivek Reddy <[email protected]>
@vivekrnv
Copy link
Contributor Author

vivekrnv commented Jan 6, 2026

@kcudnik Can you help signoff

@vivekrnv
Copy link
Contributor Author

vivekrnv commented Jan 6, 2026

/azpw run

@tjchadaga
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@vivekrnv
Copy link
Contributor Author

vivekrnv commented Jan 7, 2026

@kcudnik A gentle reminder to signoff

@vivekrnv
Copy link
Contributor Author

vivekrnv commented Jan 8, 2026

Backport request to v1.17

@tjchadaga tjchadaga merged commit 8dd59e5 into opencomputeproject:master Jan 8, 2026
3 checks passed
tjchadaga pushed a commit that referenced this pull request Jan 8, 2026
* Detect XML structure instead of relying on Doxygen version

Signed-off-by: Vivek Reddy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants