-
Notifications
You must be signed in to change notification settings - Fork 555
Detect XML structure instead of relying on Doxygen version #2240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Vivek Reddy <[email protected]>
|
@tjchadaga, @saiarcot895, @kcudnik comments for #2239 handled. Please review |
meta/parse.pl
Outdated
|
|
||
| for my $section (@sai_sections) | ||
| { | ||
| if ($section->{kind} eq "enum") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can reduce idene makint this
next if $section->{kind} ne "enum";
similar like in line 5342
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Handled
|
this change is much more clean and readable, thanks @vivekrnv |
Signed-off-by: Vivek Reddy <[email protected]>
|
@kcudnik Can you help signoff |
|
/azpw run |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@kcudnik A gentle reminder to signoff |
|
Backport request to v1.17 |
* Detect XML structure instead of relying on Doxygen version Signed-off-by: Vivek Reddy <[email protected]>
Verified in Trixie environment