Skip to content

Comments

fix fetch EK request#201

Merged
gh4683 merged 1 commit intomainfrom
fix-fetch-ek-call
Jan 9, 2026
Merged

fix fetch EK request#201
gh4683 merged 1 commit intomainfrom
fix-fetch-ek-call

Conversation

@gh4683
Copy link
Contributor

@gh4683 gh4683 commented Jan 8, 2026

In RotateAIK flow and EnrollWithHMACCHallenge flow, we incorrectly call FetchEK with Chassis Serial number instead of supervisor serial number, which resulted in errors while testing. Fixed it by passing in supervisor serial number instead

@gh4683 gh4683 marked this pull request as ready for review January 8, 2026 22:02
@gh4683 gh4683 requested a review from a team as a code owner January 8, 2026 22:02
@gh4683 gh4683 requested a review from muntazirsal January 8, 2026 22:02
@coveralls
Copy link

Pull Request Test Coverage Report for Build 20833249711

Details

  • 6 of 7 (85.71%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 52.958%

Changes Missing Coverage Covered Lines Changed/Added Lines %
service/biz/enrollz_biz.go 6 7 85.71%
Totals Coverage Status
Change from base Build 20800848059: 0.03%
Covered Lines: 2005
Relevant Lines: 3786

💛 - Coveralls

Copy link
Contributor

@muntazirsal muntazirsal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gh4683 gh4683 requested a review from gscert January 8, 2026 22:05
@gh4683 gh4683 requested a review from marcushines January 8, 2026 23:40
@gh4683 gh4683 merged commit b8cc494 into main Jan 9, 2026
11 checks passed
@gh4683 gh4683 deleted the fix-fetch-ek-call branch January 9, 2026 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants