Fix typo in openconfig-relay-agent.yang#1347
Fix typo in openconfig-relay-agent.yang#1347sumedhak27 wants to merge 4 commits intoopenconfig:masterfrom
Conversation
DHCPv6 advertise message is spelled incorrectly; correct it.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
/gcbrun |
|
/gcbrun |
|
No major YANG version changes in commit 3e4ebd2 |
|
Per OC guidance,
Backwards-incompatibility LGTM given the above. |
|
/gcbrun |
dplore
left a comment
There was a problem hiding this comment.
Module version number needs to be updated (to 0.2.0)
|
Discussed at OC Operators Meeting Oct 07: Fixing a typo in major version 0 seems reasonable. Moving to last-call for 2 weeks from now. |
|
/gcbrun |
Seems like we still have to do this? |
|
Discussed at the OC Operators Meeting on October 28th: Since the model is actually 9 years old, then it's actually possible that this is a "breaking" change, even though the version is still Our recommendation here is to make this a non-breaking change by deprecating the old-spelling and then adding the new leaf with the proper spelling. |
Change Scope
spelled leaf won't be available further.