-
Notifications
You must be signed in to change notification settings - Fork 689
Change system process args from leaf-list to leaf value #1379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
* (M) release/models/system/openconfig-procmon.yang
- Type change for process args from leaf-list to leaf
- Backwards incompatible minor version update to 0.5.0
And to kick start some discussion on this
Prior art reference from |
I am not aware of use-case and storage assumptions from the receiver side. Since Arista EOS returns single element of leaf-list unparsed as full string, it safe to assume some operator might be using this. From a backward compatibility perspective, can we make |
Well to be fair, you are complying to the data type, just not the description as it is defined today. I don't think we need the complexity of a union at all here - esp. for a piece of data that is imo mostly going to take up resources w/ potentially not much usage. If we update the description to comply to EOS current behavior, it negates the necessity of a leaf-list. If we change this to a singleton leaf, it would be backwards incompatible but EOS could marshal the same as the leaf-list element today. I'd be curious if there are any other current implementations out there and current behavior. And is arg parsing really necessary here to be the responsibility of the element publishing the data? |
|
/gcbrun |
|
No major YANG version changes in commit 4c888d1 |
Change Scope
During analysis of
/system/processes/process/state/argsit was observed thatimplementation behaviors may not correspond to the definition of this leaf.
In the current published
0.4.0version ofopenconfig-procmon.yang,argsis a leaf-list calling for implementations to parse the command line arguments
for every running process and pack each into precise elements of the leaf-list.
While this is entirely possible, there is the additional overhead associated
with parsing every PID and the overall usage of such data that should be
considered.
This proposal is for flattening the complexity and returning process cmdline
args as a single string as would be retreived by
procfs(for Linux-basedsystems)
NOTE: This change is backwards incompatible per YANG specifications however
this is about current shipping implemention behaviors and the usage around this
data
Platform Implementations
not-supportednot-supportednot-supported