Skip to content

Update GHA uses#560

Merged
sudo-bmitch merged 1 commit intoopencontainers:mainfrom
sudo-bmitch:pr-update-gha
Jan 23, 2025
Merged

Update GHA uses#560
sudo-bmitch merged 1 commit intoopencontainers:mainfrom
sudo-bmitch:pr-update-gha

Conversation

@sudo-bmitch
Copy link
Contributor

@sudo-bmitch sudo-bmitch commented Jan 16, 2025

We have a lot of stale actions. This bumps everything to the latest release.

  • actions/checkout v3 -> v4
  • actions/setup-go v3 -> v5
  • docker/login-action v2 -> v3
  • actions/upload-artifact v3 -> v4
  • Replace deprecated set-output with $GITHUB_OUTPUT file

Replaces #510

- actions/checkout v3 -> v4
- actions/setup-go v3 -> v5
- docker/login-action v2 -> v3
- actions/upload-artifact v3 -> v4
- Replace deprecated set-output with $GITHUB_OUTPUT file

Signed-off-by: Brandon Mitchell <git@bmitch.net>
@sudo-bmitch
Copy link
Contributor Author

See #510 (comment) for details on why we don't want to delay this.

- name: Upload OCI distribution-spec conformance results as build artifact
if: always() && steps.run-conformance.outputs.has-report == 'true'
uses: actions/upload-artifact@0b7f8abb1508181956e8e162db84b466c27e18ce # v3.1.2
uses: actions/upload-artifact@65c4c4a1ddee5b72f698fdd19549f0f0fb45cf08 # v4.6.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for future update: would be nice to uses hashes for all of them, then dependabot can do these updates for us

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy to make that change. Just need to ensure dependabot is setup (it hasn't been updating this file).

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sudo-bmitch
Copy link
Contributor Author

GitHub blog post on the deprecation: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/

@opencontainers/distribution-spec-maintainers It appears we have 11 days to merge this and tag a patch release to give users an upgrade option when their CI starts breaking. We could tell users they need to run conformance from main but that would mean they are always running development tests against the development version of the spec. I'm open for other options, or suggestions on how to handle users that want to conform to older versions of the spec that we can implement in the near term. Long term I'd like to redesign conformance, move it to a separate repo that's independently versioned, and pass the spec version as a parameter.

@sudo-bmitch sudo-bmitch merged commit eeddb23 into opencontainers:main Jan 23, 2025
4 checks passed
@sudo-bmitch sudo-bmitch deleted the pr-update-gha branch January 23, 2025 15:43
@sudo-bmitch sudo-bmitch mentioned this pull request Jan 23, 2025
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants