Revert "MAINTAINERS: add new maintainers to go-digest" #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
On Tue, Jan 10, 2017 at 06:40:58AM -0800, Jonathan Boulle wrote:
Reverts opencontainers/go-digest#25
I don't know that we need to revert it, since I'd guess that the
maintainer addition will pass. Maybe just ping the remaining
maintainers to vote on #25 after the fact? It shouldn't take too long
to collect the remaining votes needed for a quorum…
|
Contributor
|
I'd be OK with after the fact voting if we get people to give their LGTMs on GitHub. |
Contributor
Author
|
feel free to close this if that happens, just wanted to be explicit I'm not
trying to sneak anything past.
…On Tue, Jan 10, 2017 at 5:21 PM Chris Aniszczyk ***@***.***> wrote:
I'd be OK with after the fact voting if we get people to give their LGTMs
on GitHub.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#26 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACewN_tRYG46SN49AJSY1aNbsIIpvpATks5rQ6-SgaJpZM4LffDo>
.
|
Contributor
|
@jonboulle @caniszczyk How do we organize this? Do we solicit the LGTMs on #25? |
Contributor
|
@jonboulle Now that we have the 5 (retroactive :() LGTMs on #25, we can close this down. Welcome @aaronlehmann and @dmcgowan! |
Contributor
|
On Tue, Jan 10, 2017 at 08:24:43AM -0800, Jonathan Boulle wrote:
feel free to close this if that happens…
I think we can close this now, since the vote is currently +5 -0 #2
(with @stevvooe, @vbatts, @jonboulle, @brendandburns, and @jstarks in
favor and @philips and @jbouzane silent). And 5/7 > 66%, so we're
over quorum.
[Edit: sorry for the late comment. Should have finished clearing my inbox before posting…]
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #25
per #25 (comment) apparently I jumped the gun, apologies.