*: consistent media-type indications #352
Merged
+7
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Every document that defines a media-type ought to declare the media-type it is defining. Signed-off-by: Vincent Batts <[email protected]>
Contributor
|
lgtm |
wking
reviewed
Sep 30, 2016
| One or more layers are ordered on top of each other to create a complete filesystem. | ||
| This document will use a concrete example to illustrate how to create and consume these filesystem layers. | ||
|
|
||
| This section defines the `application/vnd.oci.image.layer.tar+gzip` and `application/vnd.oci.image.layer.nondistributable.tar+gzip` [media type](media-types.md). |
Contributor
There was a problem hiding this comment.
“media type” → “media types”.
| The second goal is to allow multi-architecture images, through a "fat manifest" which references image manifests for platform-specific versions of an image. | ||
| The third goal is to be translatable to the [OpenContainers/runtime-spec](https://github.com/opencontainers/runtime-spec) | ||
|
|
||
| This section defines the `application/vnd.oci.image.manifest.list.v1+json` and `application/vnd.oci.image.manifest.v1+json` [media type](media-types.md). |
Contributor
There was a problem hiding this comment.
“media type” → “media types”.
Contributor
|
LGTM after cleanup of minor nits from @wking |
vbatts
added a commit
to vbatts/oci-image-spec
that referenced
this pull request
Oct 1, 2016
opencontainers#352 (comment) Signed-off-by: Vincent Batts <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every document that defines a media-type ought to declare the media-type
it is defining.
#349 (comment)
Signed-off-by: Vincent Batts [email protected]