image-layout: some schema #428
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
On Mon, Oct 31, 2016 at 12:48:28PM -0700, Vincent Batts wrote:
I like this name, but the pattern so far has been to use *-schema.json |
Contributor
|
agree w/wking |
wking
reviewed
Nov 2, 2016
schema/image-layout.json
Outdated
| "properties": { | ||
| "imageLayoutVersion": { | ||
| "description": "version of the OCI image-layout", | ||
| "type": "string" |
Contributor
There was a problem hiding this comment.
This should probably be an enum with 1.0.0 as the only option.
vbatts
force-pushed
the
image-layout-schema
branch
from
cb64297 to
c7ff884
Compare
Member
Author
|
PTAL |
Contributor
|
c7ff884 looks good to me.
|
Contributor
|
is wanting rebase |
Contributor
|
@vbatts needs rebase |
vbatts
force-pushed
the
image-layout-schema
branch
2 times, most recently
from
08355f8 to
2d4716f
Compare
Member
Author
|
updated. PTAL. |
Contributor
|
there's no "MUST" here anymore |
Member
Author
|
@jonboulle you're right! |
vbatts
changed the title
vbatts
force-pushed
the
image-layout-schema
branch
from
2d4716f to
75db538
Compare
Member
Author
|
updated. PTAL. |
Contributor
|
lgtm some |
Contributor
|
75db538 looks good to me.
|
vbatts
force-pushed
the
image-layout-schema
branch
from
75db538 to
616cef0
Compare
Member
Author
|
ugggggh. such rebase. Why does the schema fs have to include modtime? updated.PTAL. |
vbatts
force-pushed
the
image-layout-schema
branch
from
616cef0 to
b779042
Compare
Member
Author
|
.. omg ... |
Contributor
|
vincent |
Contributor
|
lgtm |
Contributor
|
LGTM |
Contributor
|
@vbatts lol |
Signed-off-by: Vincent Batts <[email protected]>
vbatts
force-pushed
the
image-layout-schema
branch
from
b779042 to
694055e
Compare
Member
Author
|
🤕 |
Contributor
|
lgtm |
Member
Author
|
bump |
Contributor
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vincent Batts [email protected]