Skip to content

descriptor: MUST URIs and SHOULD http(s) for descriptor's 'urls' #442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 16, 2016
Merged

descriptor: MUST URIs and SHOULD http(s) for descriptor's 'urls' #442

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion descriptor.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,9 @@ The following fields contain the primary properties that constitute a Descriptor

- **`urls`** *array*

This OPTIONAL property specifies a list of URLs from which this object MAY be downloaded.
This OPTIONAL property specifies a list of URIs from which this object MAY be downloaded.
Each entry MUST conform to [RFC 3986][rfc3986].
Entries SHOULD use the `http` and `https` schemes, as defined in [RFC 7230][rfc7230-s2.7].
Copy link
Contributor

@jonboulle jonboulle Nov 21, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should https only would be nicer :-)

Copy link
Contributor Author

@wking wking Nov 21, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no danger of using a maliciously substituted blob, because you'll hash it when you get it. Using HTTP just means detecting that sort of denial of service is more expensive. And it means packet sniffers can see what you're asking for. I expect there are situations where both of those are acceptable risks.


### Reserved

Expand Down Expand Up @@ -117,3 +119,6 @@ The following example describes a [_Manifest_](manifest.md#image-manifest) with
"digest": "sha256:5b0bcabd1ed22e9fb1310cf6c2dec7cdef19f0ad69efa1f392e94a4333501270"
}
```

[rfc3986]: https://tools.ietf.org/html/rfc3986
[rfc7230-s2.7]: https://tools.ietf.org/html/rfc7230#section-2.7