Skip to content

Conversation

@wking
Copy link
Contributor

@wking wking commented Jan 23, 2017

Only use the auto-ranging when Travis tells us what the range is. Use our EPOCH_TEST_COMMIT-based range in all other cases.

This may fix the issue we've been having with #514.

wking added 2 commits January 23, 2017 15:44
Only use the auto-ranging when Travis tells us what the range is.  Use
our EPOCH_TEST_COMMIT-based range in all other cases.

ifdef is described in [1].

[1]: https://www.gnu.org/software/make/manual/html_node/Conditional-Syntax.html

Signed-off-by: W. Trevor King <[email protected]>
To make make debugging Travis environment issues more straightforward.

Signed-off-by: W. Trevor King <[email protected]>
@vbatts
Copy link
Member

vbatts commented Jan 24, 2017

LGTM

Approved with PullApprove

install: true

script:
- env | grep TRAVIS_
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this?

A way to see what Travis-specific variables were set for a given build.

@jonboulle
Copy link
Contributor

jonboulle commented Jan 24, 2017

lgtm

Approved with PullApprove

@jonboulle jonboulle merged commit 2d7ee1a into opencontainers:master Jan 24, 2017
@wking wking deleted the makefile-travis-ifdef branch January 25, 2017 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants