image-index: delete the extra fields #576
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
On Thu, Feb 16, 2017 at 10:33:00PM -0800, Zhou Hao wrote:
I do not understand why this field is added and it is not used.
‘elements’ was part of the discussion in #533 and #546. @vbatts meant
to drop it (see [1]), but looks like this bit slipped through. +1 to
removing it.
[1]: #533 (comment)
|
Contributor
|
Please rebase. |
Signed-off-by: zhouhao <[email protected]>
Author
|
rebased. PTAL |
Contributor
|
LGTM |
Author
|
@vbatts @jonboulle @philips PTAL |
Contributor
|
LGTM |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I do not understand why this field is added and it is not used.
Signed-off-by: zhouhao [email protected]